Fixed ESLint issues in test files (#1964)

Author: mehra-sourav

test/integration/arts.test.js

@@ -47,6 +47,7 @@ describe("Arts", function () {
           return done();
         });
     });
+
     it("Should return 401, for Unauthenticated User", function (done) {
       chai
         .request(app)
@@ -111,6 +112,7 @@ describe("Arts", function () {
           return done();
         });
     });
+
     it("Should return 401, for Unauthenticated User", function (done) {
       chai
         .request(app)

test/integration/auth.test.js

@@ -51,6 +51,7 @@ describe("auth", function () {
     expect(res).to.have.status(302);
     expect(res.headers.location).to.equal(githubOauthURL);
   });
+
   it("should redirect the user to new sign up flow if they are have incomplete user details true", async function () {
     const redirectURL = "https://my.realdevsquad.com/new-signup";
 

test/integration/authorizeRoles.test.js

@@ -182,6 +182,7 @@ describe("authorizeRoles", function () {
           return done();
         });
     });
+
     it("should return server error for super user on route with invalid required role", function (done) {
       chai
         .request(app)
@@ -195,6 +196,7 @@ describe("authorizeRoles", function () {
           return done();
         });
     });
+
     it("should return server error for app owner on route with invalid required role", function (done) {
       chai
         .request(app)

test/integration/contributions.test.js

@@ -58,9 +58,11 @@ describe("Contributions", function () {
     task.isNoteworthy = false;
     await testModel.updateTask(task);
   });
+
   afterEach(function () {
     sinon.restore();
   });
+
   describe("GET /contributions/{username}", function () {
     it("Should get all the contributions of the user", function (done) {
       sinon.stub(githubService, "fetchPRsByUser").returns(githubPRInfo.prakash);
@@ -104,6 +106,7 @@ describe("Contributions", function () {
           return done();
         });
     });
+
     it("Should respond 404 for unregistered user", function (done) {
       chai
         .request(app)
@@ -118,6 +121,7 @@ describe("Contributions", function () {
           return done();
         });
     });
+
     it("Should respond empty object when user has no pr and task available", function (done) {
       sinon.stub(githubService, "fetchPRsByUser").returns(githubPRInfo.userWithNoPrs);
       chai

test/integration/discord.test.js

@@ -88,6 +88,7 @@ describe("test discord actions", function () {
       ];
       await Promise.all(addGroupRolesPromises);
     });
+
     afterEach(async function () {
       await cleanDb();
     });

test/integration/discordactions.test.js

@@ -64,6 +64,7 @@ describe("Discord actions", function () {
   let discordId = "";
   let fetchStub;
   let jwt;
+
   beforeEach(async function () {
     fetchStub = sinon.stub(global, "fetch");
     userId = await addUser(userData[0]);
@@ -106,6 +107,7 @@ describe("Discord actions", function () {
           return done();
         });
     });
+
     it("Should throw error if failed to update a picture", function (done) {
       fetchStub.returns(
         Promise.resolve({
@@ -132,6 +134,7 @@ describe("Discord actions", function () {
   describe("GET /discord-actions/groups", function () {
     let newGroupData;
     let allIds = [];
+
     before(async function () {
       const addUsersPromises = userData.map((user) => userModel.add({ ...user }));
       const responses = await Promise.all(addUsersPromises);
@@ -209,6 +212,7 @@ describe("Discord actions", function () {
 
   describe("POST /discord-actions/roles", function () {
     let roleid;
+
     beforeEach(async function () {
       const discordRoleModelPromise = [
         discordRoleModel.add(groupData[0]),
@@ -224,6 +228,7 @@ describe("Discord actions", function () {
       sinon.restore();
       await cleanDb();
     });
+
     it("should not be able to add role if it is not a group type role", async function () {
       const fetchStub = sinon.stub(discordRolesModel, "isGroupRoleExists");
 
@@ -257,6 +262,7 @@ describe("Discord actions", function () {
 
       fetchStub.restore();
     });
+
     it("should allow role to be added", async function () {
       fetchStub.returns(
         Promise.resolve({
@@ -275,6 +281,7 @@ describe("Discord actions", function () {
       expect(res.body).to.be.an("object");
       expect(res.body.message).to.equal("Role added successfully!");
     });
+
     it("should create a reason and pass it down to the bot, on adding the role to the user", async function () {
       fetchStub.returns(
         Promise.resolve({
@@ -298,6 +305,7 @@ describe("Discord actions", function () {
         `Action initiator's username=>ankur and id=${userId}`
       );
     });
+
     it("should not allow unknown role to be added to user", async function () {
       const res = await chai
         .request(app)
@@ -309,6 +317,7 @@ describe("Discord actions", function () {
       expect(res.body).to.be.an("object");
       expect(res.body.message).to.equal("Permission denied. Cannot add the role.");
     });
+
     it("should not allow role to be added when userid does not belong to authenticated user", async function () {
       const res = await chai
         .request(app)
@@ -321,6 +330,7 @@ describe("Discord actions", function () {
       expect(res.body.message).to.equal("Permission denied. Cannot add the role.");
     });
   });
+
   describe("DELETE /discord-actions/roles", function () {
     let roleid;
 
@@ -385,6 +395,7 @@ describe("Discord actions", function () {
         `Action initiator's username=>ankur and id=${userId}`
       );
     });
+
     it("should not allow unknown role to be deleted from user", async function () {
       const res = await chai
         .request(app)
@@ -396,6 +407,7 @@ describe("Discord actions", function () {
       expect(res.body).to.be.an("object");
       expect(res.body.message).to.equal("Permission denied. Cannot delete the role.");
     });
+
     it("should not allow role to be deleted when userid does not belong to authenticated user", async function () {
       const res = await chai
         .request(app)
@@ -407,6 +419,7 @@ describe("Discord actions", function () {
       expect(res.body).to.be.an("object");
       expect(res.body.message).to.equal("Permission denied. Cannot delete the role.");
     });
+
     it("should handle internal server error", function (done) {
       chai
         .request(app)
@@ -472,6 +485,7 @@ describe("Discord actions", function () {
 
   describe("POST /discord-actions/nickname/status", function () {
     let jwtToken;
+
     beforeEach(async function () {
       const userData2 = { ...userData[1] };
       delete userData2.discordId;
@@ -562,6 +576,7 @@ describe("Discord actions", function () {
         });
     }).timeout(10000);
   });
+
   describe("POST /discord-actions/discord-roles", function () {
     before(async function () {
       const value = [discordRoleModel.add(groupData[0]), discordRoleModel.add(groupData[1])];
@@ -596,6 +611,7 @@ describe("Discord actions", function () {
 
   describe("PUT /discord-actions/group-idle-7d", function () {
     let allIds;
+
     beforeEach(async function () {
       userData[0].roles = { archived: false };
       userData[1].roles = { archived: false };
@@ -695,6 +711,7 @@ describe("Discord actions", function () {
         })
       );
     });
+
     afterEach(async function () {
       sinon.restore();
       await cleanDb();

test/integration/events.test.js

@@ -245,6 +245,7 @@ describe("events", function () {
     let service;
     let superUserAuthToken;
     let memberAuthToken;
+
     beforeEach(async function () {
       const superUser = userData[4];
       const member = userData[6];
@@ -483,6 +484,7 @@ describe("events", function () {
     let service;
     let superUserAuthToken;
     let memberAuthToken;
+
     beforeEach(async function () {
       const superUser = userData[4];
       const member = userData[6];
@@ -552,6 +554,7 @@ describe("events", function () {
   describe("POST /events/:id/codes", function () {
     let service;
     let superUserAuthToken;
+
     beforeEach(async function () {
       const superUser = userData[4];
       const superUserId = await addUser(superUser);
@@ -674,6 +677,7 @@ describe("events", function () {
   describe("GET /events/:id/codes - getEventCodes", function () {
     let service;
     let superUserAuthToken;
+
     beforeEach(async function () {
       const superUser = userData[4];
       const superUserId = await addUser(superUser);
@@ -728,6 +732,7 @@ describe("events", function () {
     let service;
     let superUserAuthToken;
     let memberAuthToken;
+
     beforeEach(async function () {
       const superUser = userData[4];
       const member = userData[6];

test/integration/extensionRequests.test.js

@@ -212,6 +212,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("should return success response and all extension requests with query params", function (done) {
       chai
         .request(app)
@@ -283,6 +284,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return success response after adding the extension request (sending assignee username)", function (done) {
       chai
         .request(app)
@@ -310,6 +312,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return failure response after adding the extension request (sending wrong assignee info)", function (done) {
       chai
         .request(app)
@@ -333,6 +336,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return fail response if someone try to create a extension request for someone else and is not a super user", function (done) {
       chai
         .request(app)
@@ -360,6 +364,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return fail response if task with the taskId doesn't exists", function (done) {
       chai
         .request(app)
@@ -385,6 +390,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return fail response if task belongs to someone else", function (done) {
       chai
         .request(app)
@@ -410,6 +416,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return fail response if the new ETA falls before old ETA", function (done) {
       chai
         .request(app)
@@ -434,6 +441,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return fail response if extension request for a task already exists", function (done) {
       chai
         .request(app)
@@ -458,6 +466,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("Should return success response after adding the extension request and also there should be a log for the same", function (done) {
       chai
         .request(app)
@@ -524,6 +533,7 @@ describe("Extension Requests", function () {
           return done();
         });
     });
+
     it("should return failure response if no extension request found with :id", function (done) {
       chai
         .request(app)
@@ -861,6 +871,7 @@ describe("Extension Requests", function () {
           return null;
         });
     });
+
     it("Extension request log should contain extensionRequestId upon denying request", function (done) {
       chai
         .request(app)
@@ -898,6 +909,7 @@ describe("Extension Requests", function () {
         });
     });
   });
+
   describe("Updating extension request detail", function () {
     it("Should create a log when SU changes the extension request's title", async function () {
       const newTitle = "new-title";

test/integration/external-accounts.test.js

@@ -356,6 +356,7 @@ describe("External Accounts", function () {
         rdsDiscordServerUsers: 3,
       });
     });
+
     it("Should Un-Archive Users With Archived as True and in RDS Discord Server", async function () {
       await userModel.add(usersFromRds[2]); // archivedAndInDiscord
 

test/integration/fcmToken.test.js

@@ -17,6 +17,7 @@ describe("Fcm Token Test", function () {
     userId0 = await addUser(userData0);
     userIdToken0 = authService.generateAuthToken({ userId: userId0 });
   });
+
   afterEach(async function () {
     await cleanDb();
   });
@@ -58,6 +59,7 @@ describe("Fcm Token Test", function () {
       expect(response).to.have.status(409);
       expect(response.body.message).equals("Device Already Registered");
     });
+
     it("should have fcm token", async function () {
       const fcmTokenData = {};
       const response = await chai
@@ -70,6 +72,7 @@ describe("Fcm Token Test", function () {
       expect(response).to.have.status(400);
       expect(response.body.message).equals('"fcmToken" is required');
     });
+
     it("should have user token", async function () {
       const fcmTokenData = { fcmToken: "iedsijdsdj" };