- Added dev feature flag through the middleware to control access to the /tasks/orphaned-tasks API.

- Implemented negative test cases for the /tasks/orphaned-tasks endpoint:
  - Tested the scenario where the dev flag is not provided, expecting a 404 status code with a "Route not found" message.
  - Tested the scenario where the database query fails, ensuring the API responds with a 500 status code and an appropriate error message.

Author: VinuB-Dev

controllers/tasks.js

@@ -12,7 +12,8 @@ const { getPaginatedLink } = require("../utils/helper");
 const { updateUserStatusOnTaskUpdate, updateStatusOnTaskCompletion } = require("../models/userStatus");
 const dataAccess = require("../services/dataAccessLayer");
 const { parseSearchQuery } = require("../utils/tasks");
-const { addTaskCreatedAtAndUpdatedAtFields, fetchOrphanedTasks } = require("../services/tasks");
+const { addTaskCreatedAtAndUpdatedAtFields } = require("../services/tasks");
+const tasksService = require("../services/tasks");
 const { RQLQueryParser } = require("../utils/RQLParser");
 const { getMissedProgressUpdatesUsers } = require("../models/discordactions");
 const { logType } = require("../constants/logs");
@@ -534,8 +535,8 @@ const getUsersHandler = async (req, res) => {
 
 const getOrphanedTasks = async (req, res) => {
   try {
-    const data = await fetchOrphanedTasks();
-
+    const data = await tasksService.fetchOrphanedTasks();
+    if (data.length === 0) return res.status(204).send();
     return res.status(200).json({ message: "Orphan tasks fetched successfully", data });
   } catch (error) {
     logger.error("Error in getting tasks which were abandoned", error);

routes/tasks.js

@@ -17,6 +17,7 @@ const { cacheResponse, invalidateCache } = require("../utils/cache");
 const { ALL_TASKS } = require("../constants/cacheKeys");
 const { verifyCronJob } = require("../middlewares/authorizeBot");
 const { CLOUDFLARE_WORKER, CRON_JOB_HANDLER } = require("../constants/bot");
+const { devFlagMiddleware } = require("../middlewares/devFlag");
 
 const oldAuthorizationMiddleware = authorizeRoles([APPOWNER, SUPERUSER]);
 const newAuthorizationMiddleware = authorizeAndAuthenticate(
@@ -33,7 +34,7 @@ const enableDevModeMiddleware = (req, res, next) => {
   }
 };
 
-router.get("/orphaned-tasks", tasks.getOrphanedTasks);
+router.get("/orphaned-tasks", devFlagMiddleware, tasks.getOrphanedTasks);
 router.get("/", getTasksValidator, cacheResponse({ invalidationKey: ALL_TASKS, expiry: 10 }), tasks.fetchTasks);
 router.get("/self", authenticate, tasks.getSelfTasks);
 router.get("/overdue", authenticate, authorizeRoles([SUPERUSER]), tasks.overdueTasks);

test/integration/tasks.test.js

@@ -25,7 +25,8 @@ const userDBModel = firestore.collection("users");
 const discordService = require("../../services/discordService");
 const { CRON_JOB_HANDLER } = require("../../constants/bot");
 const { logType } = require("../../constants/logs");
-
+const { INTERNAL_SERVER_ERROR } = require("../../constants/errorMessages");
+const tasksService = require("../../services/tasks");
 chai.use(chaiHttp);
 
 const appOwner = userData[3];
@@ -1654,7 +1655,7 @@ describe("Tasks", function () {
     });
 
     it("should fetch tasks assigned to archived and non-discord users", async function () {
-      const res = await chai.request(app).get("/tasks/orphaned-tasks");
+      const res = await chai.request(app).get("/tasks/orphaned-tasks?dev=true");
 
       expect(res).to.have.status(200);
       expect(res.body).to.have.property("message").that.equals("Orphan tasks fetched successfully");
@@ -1668,11 +1669,24 @@ describe("Tasks", function () {
 
       const task = abandonedTasksData[3];
       await tasksModel.add(task);
+      const res = await chai.request(app).get("/tasks/orphaned-tasks?dev=true");
+
+      expect(res).to.have.status(204);
+    });
+
+    it("should fail if dev flag is not passed", async function () {
       const res = await chai.request(app).get("/tasks/orphaned-tasks");
+      expect(res).to.have.status(404);
+      expect(res.body.message).to.be.equal("Route not found");
+    });
 
-      expect(res).to.have.status(200);
-      expect(res.body).to.have.property("message").that.equals("Orphan tasks fetched successfully");
-      expect(res.body.data).to.be.an("array").with.lengthOf(0);
+    it("should handle errors gracefully if the database query fails", async function () {
+      sinon.stub(tasksService, "fetchOrphanedTasks").rejects(new Error(INTERNAL_SERVER_ERROR));
+
+      const res = await chai.request(app).get("/tasks/orphaned-tasks?dev=true");
+
+      expect(res).to.have.status(500);
+      expect(res.body.message).to.be.equal(INTERNAL_SERVER_ERROR);
     });
   });
 });