Skip to content

Commit 9ad3048

Browse files
fix/function-name
1 parent d608d9c commit 9ad3048

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

middlewares/oooRoleCheckMiddleware.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const { SUPERUSER } = require("../constants/roles");
1313
* @param {CustomResponse} res - The response object
1414
* @param {NextFunction} next - The next middleware function
1515
*/
16-
export const conditionalOooChecks = (req: CustomRequest, res: CustomResponse, next: NextFunction) => {
16+
export const oooRoleCheckMiddleware = (req: CustomRequest, res: CustomResponse, next: NextFunction) => {
1717
const requestType = req.body?.type;
1818

1919

models/requests.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,9 @@ export const getRequests = async (query: any) => {
8282

8383
if (id) {
8484
const requestDoc = await requestModel.doc(id).get();
85-
if (!requestDoc.exists) {
86-
85+
if (!requestDoc.exists) {
8786
return null;
8887
}
89-
9088
return {
9189
id: requestDoc.id,
9290
...requestDoc.data(),

routes/requests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const router = express.Router();
33
const authorizeRoles = require("../middlewares/authorizeRoles");
44
const { SUPERUSER } = require("../constants/roles");
55
import authenticate from "../middlewares/authenticate";
6-
import { conditionalOooChecks } from "../middlewares/oooRoleCheckMiddleware";
6+
import { oooRoleCheckMiddleware } from "../middlewares/oooRoleCheckMiddleware";
77
import {
88
createRequestsMiddleware,
99
updateRequestsMiddleware,
@@ -23,6 +23,6 @@ import { verifyDiscordBot } from "../middlewares/authorizeBot";
2323
router.get("/", getRequestsMiddleware, getRequestsController);
2424
router.post("/", skipAuthenticateForOnboardingExtensionRequest(authenticate, verifyDiscordBot), createRequestsMiddleware, createRequestController);
2525
router.put("/:id",authenticate, authorizeRoles([SUPERUSER]), updateRequestsMiddleware, updateRequestController);
26-
router.patch("/:id", authenticate, conditionalOooChecks, updateRequestValidator, updateRequestBeforeAcknowledgedController);
26+
router.patch("/:id", authenticate, oooRoleCheckMiddleware, updateRequestValidator, updateRequestBeforeAcknowledgedController);
2727
module.exports = router;
2828

0 commit comments

Comments
 (0)