Skip to content

Commit bb74cdd

Browse files
fix:reverted-middleware
1 parent 47a6b98 commit bb74cdd

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

controllers/oooRequests.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,22 @@ export const acknowledgeOooRequest = async (
174174
next: NextFunction
175175
): Promise<OooRequestResponse> => {
176176
try {
177+
const dev = req.query.dev === "true";
178+
if(!dev) return res.boom.notImplemented("Feature not implemented");
179+
180+
const isSuperuser = req.userData?.roles?.super_user;
181+
if (!isSuperuser) {
182+
return res.boom.forbidden(UNAUTHORIZED_TO_UPDATE_REQUEST);
183+
}
184+
177185
const requestBody = req.body;
178186
const superUserId = req.userData.id;
179187
const requestId = req.params.id;
180188

189+
if (!requestId) {
190+
return res.boom.badRequest(REQUEST_ID_REQUIRED);
191+
}
192+
181193
const response = await oooRequestService.acknowledgeOooRequest(requestId, requestBody, superUserId);
182194

183195
return res.status(200).json({

routes/requests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,6 @@ import { verifyDiscordBot } from "../middlewares/authorizeBot";
2323
router.get("/", getRequestsMiddleware, getRequestsController);
2424
router.post("/", skipAuthenticateForOnboardingExtensionRequest(authenticate, verifyDiscordBot), createRequestsMiddleware, createRequestController);
2525
router.put("/:id",authenticate, authorizeRoles([SUPERUSER]), updateRequestsMiddleware, updateRequestController);
26-
router.patch("/:id", authenticate, devFlagMiddleware, authorizeRoles([SUPERUSER]), updateRequestValidator, updateRequestBeforeAcknowledgedController);
26+
router.patch("/:id", authenticate, updateRequestValidator, updateRequestBeforeAcknowledgedController);
2727
module.exports = router;
2828

0 commit comments

Comments
 (0)