bug-fix-github_auth (#2504)

Suvidh-kaushik · web-flow · commit d7627c067486 · 2025-11-15T20:19:27.000+05:30
diff --git a/controllers/auth.js b/controllers/auth.js
@@ -188,7 +188,8 @@ const githubAuthCallback = (req, res, next) => {
       }
 
       const userDataFromDB = await users.fetchUser({ email: userData.email });
-      if (userDataFromDB.userExists && userDataFromDB.user?.role !== ROLES.DEVELOPER) {
+      const userRole = userDataFromDB.user?.role;
+      if (userDataFromDB.userExists && userRole && userRole !== ROLES.DEVELOPER) {
         return res.status(403).json({
           message: "Github Login is restricted for non-developers,please use Google Login",
         });
diff --git a/controllers/users.js b/controllers/users.js
@@ -500,6 +500,9 @@ const updateSelf = async (req, res, next) => {
         }
         await userQuery.setIncompleteUserDetails(userId);
       }
+      if (role) {
+        return res.boom.forbidden("You are not authorized to perform this operation");
+      }
     }
 
     if (req.body.disabledRoles) {

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,8 @@ const githubAuthCallback = (req, res, next) => {`
`188`	`188`	`}`
`189`	`189`
`190`	`190`	`const userDataFromDB = await users.fetchUser({ email: userData.email });`
`191`		`- if (userDataFromDB.userExists && userDataFromDB.user?.role !== ROLES.DEVELOPER) {`
	`191`	`+ const userRole = userDataFromDB.user?.role;`
	`192`	`+ if (userDataFromDB.userExists && userRole && userRole !== ROLES.DEVELOPER) {`
`192`	`193`	`return res.status(403).json({`
`193`	`194`	`message: "Github Login is restricted for non-developers,please use Google Login",`
`194`	`195`	`});`
Original file line number	Diff line number	Diff line change
`@@ -500,6 +500,9 @@ const updateSelf = async (req, res, next) => {`
`500`	`500`	`}`
`501`	`501`	`await userQuery.setIncompleteUserDetails(userId);`
`502`	`502`	`}`
	`503`	`+ if (role) {`
	`504`	`+ return res.boom.forbidden("You are not authorized to perform this operation");`
	`505`	`+ }`
`503`	`506`	`}`
`504`	`507`
`505`	`508`	`if (req.body.disabledRoles) {`