Handling the conflict case where email has been already taken in AWS (#2271)

* Fix: change env variables from obj to string

This resolves the error faced in staging for the discord command developed by me /grant-aws-access, we were facing this issue when running this in stgaging, this is becuase in the node-config the values were being set as obj with name field as the actual value

* lint-fix

* removing console log statement

* removing the extra log

* handling conflict case, where user with email already exists in AWS

Author: vikhyat187

controllers/awsAccess.ts

@@ -21,6 +21,12 @@ export const addUserToAWSGroup = async (req, res) => {
       if (awsUserId === null){
         // We need to create the user in AWS before and then fetch its Id
         userCreationResponse = await createUser(userInfoData.user.username, userInfoData.user.email);
+        
+        if (userCreationResponse.conflict){
+          return res.status(400).json({
+            error: `Username or Email is already being used, please use another email / username for creating account in AWS`
+          })
+        }
         awsUserId = userCreationResponse.UserId;
       }
 

utils/awsFunctions.ts

@@ -67,7 +67,10 @@ import {
       const command = new CreateUserCommand(params);
       return (await client.send(command));
     } catch (error) {
-      console.error(`The error from create user ${error}`);
+      if (error.__type === 'ConflictException'){
+        return { conflict: true };
+      }
+
       throw new Error(`Failed to create user: ${error instanceof Error ? error.message : String(error)}`);
     }
   };
@@ -93,7 +96,6 @@ export const addUserToGroup = async (groupId: string, awsUserId: string): Promis
       const command = new CreateGroupMembershipCommand(params);
       return (await client.send(command));
     } catch (error) {
-      console.error("Error adding user to group:", error);
       if (error.__type === 'ConflictException'){
         return { conflict: true };
       }