Skip to content

Commit a364608

Browse files
authored
Merge pull request #1360 from Real-Dev-Squad/develop
Dev to Main Sync
2 parents 6ea279b + e25bb66 commit a364608

File tree

2 files changed

+31
-11
lines changed

2 files changed

+31
-11
lines changed

__tests__/Unit/Components/Tasks/TaskStatusDropdown.test.tsx

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ describe('TaskStatusDropdown', () => {
109109

110110
it('should show text Done as selected option when a task with completed status is passed down.', () => {
111111
const oldProgress = 100;
112-
const oldStatus = BACKEND_TASK_STATUS.DONE;
112+
const oldStatus = BACKEND_TASK_STATUS.COMPLETED;
113113

114114
render(
115115
<TaskStatusDropdown
@@ -146,6 +146,20 @@ describe('TaskStatusDropdown', () => {
146146
const msgTag = screen.queryByTestId('msg');
147147
expect(msgTag).toBeNull();
148148
});
149+
it('should show text Backlog when a task with Backlog status is passed down.', () => {
150+
const oldProgress = 100;
151+
const oldStatus = BACKEND_TASK_STATUS.BACKLOG;
152+
153+
render(
154+
<TaskStatusDropdown
155+
oldProgress={oldProgress}
156+
oldStatus={oldStatus}
157+
onChange={onChange}
158+
/>
159+
);
160+
const element = screen.getByTestId('task-status-backlog');
161+
expect(element).toHaveTextContent('Backlog');
162+
});
149163
describe('TaskDropDownModel', () => {
150164
const handleProceed = jest.fn();
151165
const resetProgressAndStatus = jest.fn();

src/components/tasks/TaskStatusDropdown.tsx

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ const TaskStatusSelect = ({
2727
taskStatus,
2828
testIdPrefix = 'task-status',
2929
}: TaskStatusSelectProps) => {
30+
if (newStatus === BACKEND_TASK_STATUS.COMPLETED) {
31+
newStatus = BACKEND_TASK_STATUS.DONE;
32+
}
33+
3034
return (
3135
<select
3236
className={styles.taskStatusUpdate}
@@ -67,10 +71,6 @@ export function TaskStatusDropdown({
6771
});
6872
const [message, setMessage] = useState('');
6973

70-
if (oldStatus === BACKEND_TASK_STATUS.COMPLETED) {
71-
BACKEND_TASK_STATUS.DONE = BACKEND_TASK_STATUS.COMPLETED;
72-
}
73-
7474
const getAvailableTaskStatuses = () => {
7575
return Object.entries(BACKEND_TASK_STATUS).filter(
7676
([_, value]) => !EXCLUDED_STATUSES.includes(value)
@@ -159,12 +159,18 @@ export function TaskStatusDropdown({
159159
}
160160
data-testid={isDevMode ? 'task-status-label' : undefined}
161161
>
162-
Status:
163-
<TaskStatusSelect
164-
newStatus={newStatus}
165-
handleChange={handleChange}
166-
taskStatus={taskStatus}
167-
/>
162+
Status:{' '}
163+
{newStatus === BACKEND_TASK_STATUS.BACKLOG ? (
164+
<span data-testid="task-status-backlog">
165+
{beautifyStatus(newStatus)}
166+
</span>
167+
) : (
168+
<TaskStatusSelect
169+
newStatus={newStatus}
170+
handleChange={handleChange}
171+
taskStatus={taskStatus}
172+
/>
173+
)}
168174
</label>
169175
<TaskDropDownModel
170176
message={message}

0 commit comments

Comments
 (0)