chore: remove dev flag from profile page (#1114)

* chore: remove dev flag from profile page

* fix: add test description

* fix: naming for profile route test

Author: MayankBansal12

app/controllers/profile.js

@@ -9,16 +9,7 @@ const BASE_URL = APPS.API_BACKEND;
 
 export default class ProfileController extends Controller {
   @service toast;
-  @service router;
-  get isDev() {
-    if (
-      this.router.currentRoute &&
-      this.router.currentRoute.queryParams.dev === 'true'
-    ) {
-      return this.router.currentRoute.queryParams.dev;
-    }
-    return false;
-  }
+
   get imageUploadUrl() {
     return `${BASE_URL}/users/picture`;
   }

app/routes/profile.js

@@ -10,12 +10,7 @@ const BASE_URL = APPS.API_BACKEND;
 export default class ProfileRoute extends Route {
   @service toast;
   @service fastboot;
-  @service router;
-  beforeModel(transition) {
-    if (transition?.to?.queryParams?.dev !== 'true') {
-      this.router.transitionTo('/page-not-found');
-    }
-  }
+
   async model() {
     try {
       const res = await fetch(`${BASE_URL}/users/isDeveloper`, {

tests/unit/routes/profile-test.js

@@ -10,34 +10,15 @@ module('Unit | Route | profile', function (hooks) {
   hooks.beforeEach(function () {
     this.fetchStub = sinon.stub(window, 'fetch');
     this.route = this.owner.lookup('route:profile');
-    sinon.stub(this.route.router, 'transitionTo');
   });
 
   hooks.afterEach(function () {
     this.fetchStub.restore();
-    sinon.restore();
   });
 
-  test('redirects to 404 page if dev flag is not present', function (assert) {
-    const transition = { to: { queryParams: { dev: 'false' } } };
-
-    this.route.beforeModel(transition);
-
-    assert.ok(
-      this.route.router.transitionTo.calledOnceWith('/page-not-found'),
-      'Redirected to /page-not-found when dev is not true',
-    );
-  });
-
-  test('allows access when dev flag is true', function (assert) {
-    const transition = { to: { queryParams: { dev: 'true' } } };
-
-    this.route.beforeModel(transition);
-
-    assert.ok(
-      this.route.router.transitionTo.notCalled,
-      'No redirection occurs when dev query param is true',
-    );
+  test('profile route exists and is accessible', function (assert) {
+    let route = this.owner.lookup('route:profile');
+    assert.ok(route, 'Test the route exists and is accessible');
   });
 
   test('it fetches and transforms model data correctly', async function (assert) {