chore: remove dev flag from new signup page (#1115)

Author: MayankBansal12

app/controllers/new-signup.js

@@ -19,10 +19,9 @@ import apiRequest from '../utils/api-request';
 export default class NewSignupController extends Controller {
   @service toast;
 
-  queryParams = ['currentStep', 'dev', 'signupDev'];
+  queryParams = ['currentStep', 'dev'];
 
   @tracked dev;
-  @tracked signupDev;
   @tracked isLoading = false;
   @tracked isButtonDisabled = true;
   @tracked error = '';
@@ -42,8 +41,7 @@ export default class NewSignupController extends Controller {
   };
 
   get isDevMode() {
-    // replace this signupDev with dev flag once new-signup page is not under dev flag
-    return this.signupDev === 'true';
+    return this.dev === 'true';
   }
 
   async generateUsername(firstname, lastname) {

app/routes/new-signup.js

@@ -10,14 +10,6 @@ import redirectAuth from '../utils/redirect-auth';
 export default class NewSignupRoute extends Route {
   @service toast;
   @service router;
-  isDevMode = false;
-
-  beforeModel(transition) {
-    if (transition?.to?.queryParams?.dev !== 'true') {
-      this.router.transitionTo('/page-not-found');
-    }
-    this.isDevMode = true;
-  }
 
   async model() {
     try {

tests/unit/controllers/new-signup-test.js

@@ -200,7 +200,7 @@ module('Unit | Controller | new-signup', function (hooks) {
   });
 
   test('signup catches error and shows correct error message (dev flag enabled)', async function (assert) {
-    controller.signupDev = 'true'; // replace signupDev with dev once dev is removed from new-signup
+    controller.dev = 'true';
     controller.signupDetails = {
       firstName: fakeUserData.first_name,
       lastName: fakeUserData.last_name,

tests/unit/routes/new-signup-test.js

@@ -22,28 +22,6 @@ module('Unit | Route | new-signup', function (hooks) {
     this.clock.restore();
   });
 
-  test('redirects to 404 page if dev flag is not present', function (assert) {
-    const transition = { to: { queryParams: { dev: 'false' } } };
-
-    this.route.beforeModel(transition);
-
-    assert.ok(
-      this.route.router.transitionTo.calledOnceWith('/page-not-found'),
-      'Redirected to /page-not-found when dev is not true',
-    );
-  });
-
-  test('allows new-signup page access when dev flag is true', function (assert) {
-    const transition = { to: { queryParams: { dev: 'true' } } };
-
-    this.route.beforeModel(transition);
-
-    assert.ok(
-      this.route.router.transitionTo.notCalled,
-      'Signup page accessed when dev query param is true',
-    );
-  });
-
   test('displays error in case of 401 response', async function (assert) {
     this.fetchStub.resolves(new Response(JSON.stringify({}), { status: 401 }));
     const result = await this.route.model();