fixed a bug with deleting the last tab

Author: RealFloorIsJava

src/main/java/nge/lk/mods/simpletabs/tabs/TabDisplay.java

@@ -8,7 +8,6 @@
 import net.minecraft.util.math.MathHelper;
 import org.lwjgl.input.Mouse;
 
-import java.util.Iterator;
 import java.util.Map.Entry;
 
 /**
@@ -110,9 +109,7 @@ public void handleClick(final int mouseButton) {
             assert tabUnderMouse >= 0 : "unchecked flag value";
 
             int skip = tabManager.getTabOffset() + tabUnderMouse;
-            final Iterator<Entry<String, ChatTab>> it = tabManager.getActiveTabGroup().iterator();
-            while (it.hasNext()) {
-                final Entry<String, ChatTab> tab = it.next();
+            for (final Entry<String, ChatTab> tab : tabManager.getActiveTabGroup()) {
                 if (skip-- > 0) {
                     continue;
                 }
@@ -126,7 +123,7 @@ public void handleClick(final int mouseButton) {
                     tabManager.editTab(tab.getKey(), tab.getValue());
                 } else if (mouseButton == 2) {
                     // Middle mouse button.
-                    it.remove();
+                    tabManager.deleteTab(tab.getKey());
                     resetSelectedTab();
                     tabManager.saveState();
                 }

src/main/java/nge/lk/mods/simpletabs/tabs/TabManager.java

@@ -214,6 +214,17 @@ public void makeTabActive(final String key) {
         // Invariant: The current tab is valid, so no change is needed even if the tab name doesn't exist.
     }
 
+    /**
+     * Deletes the tab with the given name.
+     *
+     * @param key The name.
+     */
+    public void deleteTab(final String key) {
+        if (doesTabExistInActiveGroup(key)) {
+            tabs.get(activeGroup).remove(key);
+        }
+    }
+
     public void resetSelectedTab() {
         activeTab = tabs.get(activeGroup).isEmpty() ? null : tabs.get(activeGroup).keySet().stream().findFirst().get();
         tabOffset = 0;
@@ -279,6 +290,11 @@ public ChatTab getActiveChat() {
         return tabs.get(activeGroup).get(activeTab);
     }
 
+    /**
+     * Fetches the prefix of the active tab.
+     *
+     * @return The prefix.
+     */
     public String getActivePrefix() {
         if (getActiveChat() != null) {
             return getActiveChat().getPrefix();