version 4.0.0

Author: kevin1024

README.md

@@ -19,7 +19,7 @@ Use the `get_new_listings` method with your username and password.  This returns
 ```python
 import evernetpy
 
-for listing in evernetpy.get_new_listings(username, password, hours_previous=24):
+for listing in evernetpy.get_new_listings(username, password):
     print listing
 ```
 
@@ -115,6 +115,7 @@ logging.getLogger().setLevel(logging.INFO)
 
 # Changelog
 
+* 4.0.0: Breaking API change: `get_new_listings` now takes a `start_date` and `end_date` optional parameter, instead of `hours_previous`
 * 3.0.0: Change `get_all_active_mls_numbers` to `get_mls_numbers`.  This is a breaking API change.
 * 2.3.0: You can now pass in date_min and date max to the `get_all_active_mls_nubmers` function
 * 2.2.1: Bugfix: now you can actually use the status parameter to get all active listings

evernetpy/__init__.py

@@ -10,7 +10,7 @@ def get_all_listings(username, password, property_types=[], areas=[], cities=[],
     return get_new_listings(
         username,
         password,
-        hours_previous=876581,
+        start_date = (datetime.datetime.utcnow() - datetime.timedelta(hours=876581)),
         property_types=property_types,
         areas=areas,
         cities=cities,
@@ -31,11 +31,13 @@ def get_mls_numbers(username, password, property_types=[], areas=[], cities=[],
             yield info.get('LN')
 
 
-def get_new_listings(username, password, hours_previous=24, property_types=[], areas=[], cities=[], status=[]):
-    begin_date = (datetime.datetime.utcnow() - datetime.timedelta(hours=hours_previous)).strftime('%Y-%m-%dT%H:%M:%S')
-    end_date = datetime.datetime.utcnow().strftime('%Y-%m-%dT%H:%M:%S')
+def get_new_listings(username, password, start_date=None, end_date=None, property_types=[], areas=[], cities=[], status=[]):
+    if not start_date:
+        start_date = (datetime.datetime.utcnow() - datetime.timedelta(hours=24)).strftime('%Y-%m-%dT%H:%M:%S')
+    if not end_date:
+        end_date = datetime.datetime.utcnow().strftime('%Y-%m-%dT%H:%M:%S')
 
-    for criteria in iterate_criteria(begin_date, end_date, property_types, areas, cities, status):
+    for criteria in iterate_criteria(start_date, end_date, property_types, areas, cities, status):
         for row in execute_listing_query(username, password, 'RetrieveListingData', criteria):
             out = dict([(c.tag.replace('{http://www.nwmls.com/Schemas/Standard/StandardXML1_2.xsd}', ''), c.text) for c in row.getchildren()])
             yield look_up_all_fields(username, password, out)

tests/integration/test_property_pull.py

@@ -1,4 +1,4 @@
-from evernetpy import get_new_listings, get_all_active_mls_numbers, get_photos, get_new_listings, get_property
+from evernetpy import get_new_listings, get_mls_numbers, get_photos, get_new_listings, get_property
 from os import environ
 import logging
 
@@ -9,6 +9,12 @@
 logging.getLogger().addHandler(console_log)
 logging.getLogger().setLevel(logging.INFO)
 
+def test_get_new_sold_listings():
+    results = get_new_listings(username, password, property_types=['RESI'])
+    for r in results:
+        if r['ST'].upper() == 'SOLD':
+            assert 'SP' in r
+
 def test_get_new_listings_unfiltered():
     results = get_new_listings(username, password)
     assert len([r for r in results])
@@ -26,7 +32,7 @@ def test_get_new_listings_filtered_by_city():
     assert all([c == 'Seattle' for c in cities])
 
 def test_get_all_active_mls_numbers():
-    results = get_all_active_mls_numbers(username, password)
+    results = get_mls_numbers(username, password)
     assert len([r for r in results])
 
 def test_get_photos():