Skip to content

Commit cebc97b

Browse files
committed
5.8.2 Release
1 parent 699d978 commit cebc97b

File tree

10 files changed

+102
-201
lines changed

10 files changed

+102
-201
lines changed

build.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ pwsh -Command "(gc -en UTF8NoBOM manifest.json) -replace 'pre%oldRev%', 'pre%qui
88
echo %quickFoldersRev% > revision.txt
99
move QuickFolders*.xpi "..\..\..\Release\_Test Versions\5.8\"
1010
pwsh -Command "Start-Sleep -m 150"
11-
rename QuickFoldersWeb.zip QuickFolders-mx-5.8.1pre%quickFoldersRev%.xpi
11+
rename QuickFoldersWeb.zip QuickFolders-mx-5.8.2pre%quickFoldersRev%.xpi

chrome/content/qf-scrollmenus.js

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
2+
/* function originally contained in scrollMenus.xul */
3+
(function(){
4+
function repeatOnDragover (evt) {
5+
var now = evt.timeStamp || (new Date()).getTime(), timeWarp = (now < tsLastRepeat);
6+
if (timeWarp || now >= (tsLastRepeat + REPEAT_DELAY_MS)) {
7+
tsLastRepeat = now;
8+
if (!timeWarp) { fnRepeat(); }
9+
}
10+
};
11+
12+
var REPEAT_DELAY_MS = 50,
13+
REPEAT_RE = /arrowscrollbox$/i,
14+
tsLastRepeat,
15+
fnRepeat;
16+
var BookmarksMenuDNDObserver = QuickFolders.popupDragObserver;
17+
// prevent the bookmarks menu from closing when a drag is held over the autorepeatbuttons
18+
// and menuseparators (bug 349932 and maybe bug 194319/bug 240709)
19+
if (BookmarksMenuDNDObserver) {
20+
BookmarksMenuDNDObserver.getObserverForNode_SMOD = BookmarksMenuDNDObserver.getObserverForNode;
21+
BookmarksMenuDNDObserver.onDragCloseTarget_SMOD = BookmarksMenuDNDObserver.onDragCloseTarget;
22+
23+
BookmarksMenuDNDObserver.getObserverForNode = function (aNode) {
24+
var observer;
25+
try {
26+
observer = BookmarksMenuDNDObserver.getObserverForNode_SMOD(aNode);
27+
} catch (ex) {}
28+
if (!observer && aNode && aNode.id == "bookmarks-menu") {
29+
observer = this.getObserverForNode(aNode.getElementsByTagName("menupopup")[0]);
30+
}
31+
return observer;
32+
};
33+
BookmarksMenuDNDObserver.onDragCloseTarget = function () {
34+
var currentObserver = this.getObserverForNode(this.mCurrentDragOverTarget);
35+
// close all the menus not hovered by the mouse
36+
for (var i=0; i < this.mObservers.length; i++) {
37+
if (currentObserver != this.mObservers[i]) {
38+
this.onDragCloseMenu(this.mObservers[i]);
39+
if (this.mObservers[i].parentNode.id == "bookmarks-menu")
40+
this.mObservers[i].hidePopup();
41+
}
42+
else {
43+
this.onDragCloseMenu(this.mCurrentDragOverTarget.id == "bookmarks-menu"
44+
? this.mCurrentDragOverTarget.getElementsByTagName("menupopup")[0]
45+
: this.mCurrentDragOverTarget.parentNode
46+
);
47+
}
48+
}
49+
};
50+
}
51+
52+
// activate autorepeatbuttons on dragover (bug 194319)
53+
document.addEventListener("dragenter", function (evt) {
54+
function removeRepeat (evt) {
55+
el.removeEventListener("dragover", repeatOnDragover, true);
56+
el.removeEventListener("dragend", removeRepeat, false);
57+
}
58+
var el = evt.originalTarget, hierarchyLimit = 3;
59+
while (el &&
60+
(el.nodeName!="toolbarbutton" ||
61+
el.id!="scrollbutton-down" && el.id!="scrollbutton-up")) { // scrollbutton-down // !REPEAT_RE.test(el.nodeName)
62+
el = (--hierarchyLimit && el.parentNode);
63+
}
64+
if (el) {
65+
tsLastRepeat = (evt.timeStamp || (new Date()).getTime()) - REPEAT_DELAY_MS;
66+
fnRepeat = function(){
67+
switch(el.id) {
68+
case "scrollbutton-down":
69+
el.parentNode.host.scrollByIndex(1,true);
70+
break;
71+
case "scrollbutton-up":
72+
el.parentNode.host.scrollByIndex(-1,true);
73+
break;
74+
}
75+
};
76+
77+
el.addEventListener("dragover", repeatOnDragover, true);
78+
el.addEventListener("dragend", removeRepeat, false);
79+
repeatOnDragover({timeStamp: evt.timeStamp});
80+
81+
}
82+
}, true);
83+
84+
})();

chrome/content/quickfolders.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ END LICENSE BLOCK */
194194
## When quickFilters activates its assistant, all icons on left to the tabs will be white
195195
## Added max version (Thunderbird 91.*) as mandated by new policies on ATN.
196196
197-
5.8 QuickFolders Pro - WIP
197+
5.8.1 QuickFolders Pro - 18/10/2021
198198
## [issue 191] Support large icon in QuickFolders toolbar buttons
199199
## [issue 203] When quickFilters activates its assistant, all icons on left to the tabs will be white
200200
## [issue 209] With some themes, tabs in Options Dialog become illegible in Thunderbird 91
@@ -210,6 +210,12 @@ END LICENSE BLOCK */
210210
## [issue 204] Thunderbird 91: Background of toolbar doesn't support some themes when set to transparent
211211
WORK IN PROGRESS / KNOWN:
212212
## [issue 208] Upgrade from TB 78 to 91.1.2 sometimes leads to invalid / "orphaned" tabs
213+
214+
5.8.2 QuickFolders Pro - WIP
215+
## [issue 5] Long folders menu scroll issues in Thunderbird 68 + 78
216+
## [issue 77] Folder list menu under tabs does not scroll
217+
## [issue 105] list of subfolders not scrolled down
218+
## [issue 67] Subfolder menu does not scroll when dragging email and list of folders is longer than fits on screen
213219
214220
-=-----------------=- PLANNED
215221
## [issue 103] Feature Request: Support copying folders
@@ -723,7 +729,7 @@ var QuickFolders = {
723729
let type = ev.type || "",
724730
id = ev.target ? (ev.target.id || "") : "no target",
725731
txt = ev ? (type + " " + id) : "";
726-
console.log("toolbarDragObserver:DnD " + txt) ;
732+
console.log("toolbarDragObserver:DnD " + txt, ev) ;
727733
},
728734

729735
canHandleMultipleItems: false,

chrome/content/scripts/qf-messenger.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-
1616
Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-folder-category.js", window, "UTF-8");
1717
Services.scriptloader.loadSubScript("chrome://quickfolders/content/qf-styles.js", window, "UTF-8");
1818
Services.scriptloader.loadSubScript("chrome://quickfolders/content/quickfolders-listener.js", window, "UTF-8");
19+
Services.scriptloader.loadSubScript("chrome://quickfolders/content/qf-scrollmenus.js", window, "UTF-8");
1920

2021
var mylisteners = {};
2122

chrome/content/scrollPatch/contents.rdf

Lines changed: 0 additions & 29 deletions
This file was deleted.

chrome/content/scrollPatch/scrollMenus.xul

Lines changed: 0 additions & 80 deletions
This file was deleted.

chrome/content/scrollPatch/scrollMenus2.xul

Lines changed: 0 additions & 82 deletions
This file was deleted.

manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"author": "Axel Grude, Klaus Buecher/opto",
1111
"name" : "QuickFolders",
1212
"description" : "__MSG_extensionDescription__",
13-
"version" : "5.8.1",
13+
"version" : "5.8.2",
1414
"default_locale": "en",
1515
"developer" : {
1616
"name" : "Axel Grude, Klaus Buecher/opto",

release-notes.html

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<b>Release 5.8.1</b>
1+
<b>Release 5.8.2</b>
22
Please note that <b>QuickFolders is compatible with the latest version of Thunderbird (91.2)</b> - if you get a message that says otherwise after updating from earlier versions (Tb68 or Tb78) or <b>if QuickFolders cannot be enabled</b> with the blue slider, simply remove it and reinstall it via "Find more Add-ons" search box on the Extensions tab of Add-ons Manager.
33

44

@@ -9,18 +9,19 @@
99

1010
You can also <a href="https://quickfolders.org/donate.html#donate">donate from here</a>.
1111

12+
<b>Maintenance Release 5.8.2</b>
13+
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/5">[issue 5]</a> Long folders menus now scroll when dragging mails to screen edge.</li>
1214

13-
<b>Improvements</b>
15+
<b>Improvements (5.8.1)</b>
1416
<ul>
1517
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/205">[issue 205]</a> When clicking "get Messages" from any tab, QuickFolders used to also jump into the folder. This behavior is actually not desired, as you may have filter rules defined which remove mail from the Inbox so jumping into the Inbox is not useful when new mail is downloaded. </li>
1618
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/191">[issue 191]</a> Support large icon in QuickFolders toolbar buttons for high resolution displays. </li>
1719
</ul>
1820

19-
<b>Bug Fixes + Miscellaneus</b>
21+
<b>Bug Fixes + Miscellaneus (5.8.1)</b>
2022
<ul>
21-
<li>
2223
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/211">[issue 211]</a> Fixed: move Folders in quickMove fails in Thunderbird 91. You can now again drag (multiple) folders from the tree to the quickMove button in order to relocate them. Or use the Shortcut Shift+M if you have a QuickFolders Pro license. </li>
23-
<a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/203">[issue 203]</a> Fixed: When the quickFilters Add-on activates its assistant, all icons on left to the tabs on the QuickFolders toolbar turned white. </li>
24+
<li> <a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/203">[issue 203]</a> Fixed: When the quickFilters Add-on activates its assistant, all icons on left to the tabs on the QuickFolders toolbar turned white. </li>
2425
<li>
2526
<a target="_blank" href="https://github.com/RealRaven2000/QuickFolders/issues/209">[issue 209]</a> Fixed: Tabs in Options Dialog become illegible in Thunderbird 91 when using dark themes with bright text. </li>
2627
<li>Fixed: In Thunderbird 91, background area behind current folder toolbar does not show correct background color from lightweight theme, even when lightweight support is enabled. </li>

revision.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
99
1+
16

0 commit comments

Comments
 (0)