Merge pull request netlify#7 from netlify/fix-double-cors

Remove CORS headers from GitHub

Author: brycekahle

api/github.go

@@ -18,7 +18,10 @@ var allowedRegexp = regexp.MustCompile("^/github/(git|contents|pulls|branches)/"
 
 func NewGitHubGateway() *GitHubGateway {
 	return &GitHubGateway{
-		proxy: &httputil.ReverseProxy{Director: director},
+		proxy: &httputil.ReverseProxy{
+			Director:  director,
+			Transport: &GitHubTransport{},
+		},
 	}
 }
 
@@ -106,3 +109,14 @@ func (gh *GitHubGateway) authenticate(w http.ResponseWriter, r *http.Request) er
 
 	return errors.New("Access to endpoint not allowed: your role doesn't allow access")
 }
+
+type GitHubTransport struct{}
+
+func (t *GitHubTransport) RoundTrip(r *http.Request) (*http.Response, error) {
+	resp, err := http.DefaultTransport.RoundTrip(r)
+	if err == nil {
+		// remove CORS headers from GitHub and use our own
+		resp.Header.Del("Access-Control-Allow-Origin")
+	}
+	return resp, err
+}