Skip to content

Can deepmerge-ts merge circular object? #119

@fatihaziz

Description

@fatihaziz

Suggestion

adding a test like this

test(`can merge circular object`, t => {
  const x = {
    a: { b: { c: `value1`, e: `im x`} },
  } as any
  x.a.b.a = x.a 
  x.a.b.b = x.a 

  const y = {
    a: { b: { c: `value2`, d: `val2` } },
    b: { b: { c: `value2`, d: `im y` } },
  } as any
  y.b.b.b = y.b 
  y.b.b.c = y.b 

  const expected = {
    a: {
      b: {
        a: x.a,
        b: x.a,
        c: `value2`,
        d: `val2`,
        e: `im x`,
      },
    },
    b: {
      b: {
        b: y.b,
        c: y.b,
        d: `im y`,
      },
    },
  }

  const merged = deepmerge(x, y)

  t.deepEqual(merged, expected)
  t.true(merged.a.b.a === merged.a)
  t.true(merged.a.b.b === merged.a)
})

there is some reason I cant test it myself on my desktop.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions