Use more strict code (comparisions, assertions, typehints) (#35)

* Use strict comparisions

* Add missing void return-type

* Add strict-type for argument in HeadersConstraint

* Use strict assertions in tests

Author: slavcodev

src/PhpUnit/HeadersConstraint.php

@@ -84,12 +84,9 @@ private static function normalizeJsonSchema($schema): stdClass
      * but OpenAPI allow scalar values. So if scalar value expected,
      * we try to cast array to scalar, using first element.
      *
-     * @param array $value
-     * @param string $type
-     *
-     * @return array
+     * @return mixed
      */
-    private static function normalizeHeaderValue(array $value, $type)
+    private static function normalizeHeaderValue(array $value, string $type)
     {
         if ($type !== 'array') {
             $value = empty($value) ? null : reset($value);

src/PhpUnit/MethodsAllowedConstraint.php

@@ -28,7 +28,7 @@ public function __construct(array $allowedMethods)
     protected function matches($other): bool
     {
         if (is_string($other)) {
-            return in_array(mb_strtoupper($other), $this->allowedMethods);
+            return in_array(mb_strtoupper($other), $this->allowedMethods, true);
         }
 
         return empty(array_diff($this->allowedMethods, array_map('mb_strtoupper', $other)));

src/PhpUnit/UriConstraint.php

@@ -49,7 +49,7 @@ public function __construct(
         $this->validator = new Validator('undefined');
     }
 
-    private function assertPathSegment(string $expectedSegment, string $actualSegment)
+    private function assertPathSegment(string $expectedSegment, string $actualSegment): void
     {
         if ($actualSegment !== $expectedSegment) {
             $this->errors[] = [
@@ -59,7 +59,7 @@ private function assertPathSegment(string $expectedSegment, string $actualSegmen
         }
     }
 
-    private function assertPathParam(string $expectedSegment, string $actualSegment)
+    private function assertPathParam(string $expectedSegment, string $actualSegment): void
     {
         $pathParamSchema = $this->pathParameters[mb_substr($expectedSegment, 1, -1)];
 

tests/PhpUnit/MethodsAllowedConstraintTest.php

@@ -18,7 +18,7 @@ class MethodsAllowedConstraintTest extends TestCase
     /** @var MethodsAllowedConstraint */
     private $constraint;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         parent::setUp();
         $this->constraint = new MethodsAllowedConstraint(['OPTIONS', 'HEAD', 'GET']);

tests/SchemaTest.php

@@ -43,7 +43,7 @@ public function failOnLoadUnsupportedVersion(): void
      */
     public function howToUseSwagger(Schema $schema): void
     {
-        $this->assertEquals(['https://api.example.com/v1'], $schema->getServers());
+        $this->assertSame(['https://api.example.com/v1'], $schema->getServers());
 
         $definitions = $schema->getDefinitionNames();
         $this->assertGreaterThan(0, count($definitions));