fix(components): do not pass children as a prop

Hyperkid123 · Hyperkid123 · commit 11f50be4f755 · 2025-04-02T11:08:42.000+02:00
diff --git a/packages/components/src/ConditionalFilter/ConditionalFilter.tsx b/packages/components/src/ConditionalFilter/ConditionalFilter.tsx
@@ -155,7 +155,7 @@ const ConditionalFilter: React.FunctionComponent<ConditionalFilterProps> = ({
       const C = typeMapper.custom;
       // make sure no invalid props are passed to the Fragment element which is mapped to the custom component
       const { key, children } = activeItem.filterValues;
-      return <C key={key} children={children} />;
+      return <C key={key}>{children}</C>;
     } else {
       throw new Error(`Invalid conditional filter component type! Expected one of ${Object.keys(conditionalFilterType)}, got ${activeItem.type}.`);
     }

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ const ConditionalFilter: React.FunctionComponent<ConditionalFilterProps> = ({`
`155`	`155`	`const C = typeMapper.custom;`
`156`	`156`	`// make sure no invalid props are passed to the Fragment element which is mapped to the custom component`
`157`	`157`	`const { key, children } = activeItem.filterValues;`
`158`		`- return <C key={key} children={children} />;`
	`158`	`+ return <C key={key}>{children}</C>;`
`159`	`159`	`} else {`
`160`	`160`	throw new Error(`Invalid conditional filter component type! Expected one of ${Object.keys(conditionalFilterType)}, got ${activeItem.type}.`);
`161`	`161`	`}`