fix(feo-interceptors): handle nav groups replacement (#2248)

Author: Hyperkid123

packages/config-utils/src/feo/feo-types.ts

@@ -78,6 +78,7 @@ export type DirectNavItem = {
   expandable?: boolean;
   // should be removed
   appId?: string;
+  groupId?: string;
   routes?: DirectNavItem[];
   navItems?: DirectNavItem[];
   bundleSegmentRef?: string;

packages/config-utils/src/feo/navigation-interceptor.test.ts

@@ -1,6 +1,8 @@
 import { DirectNavItem, FrontendCRD, Nav, SegmentRef } from './feo-types';
 import navigationInterceptor from './navigation-interceptor';
 
+import costNav from './test-nav-cost.json';
+
 describe('NavigationInterceptor', () => {
   describe('bundle segments', () => {
     // Declare shared variables outside beforeEach for shared access
@@ -727,5 +729,59 @@ describe('NavigationInterceptor', () => {
       // Assert - Verify behavior
       expect(result).toEqual(expectedResult);
     });
+
+    it('should replace navigation segments', () => {
+      const frontendName = 'cost-management';
+      const frontendCRD: FrontendCRD = {
+        objects: [
+          {
+            metadata: {
+              name: frontendName,
+            },
+            spec: {
+              frontend: {
+                paths: ['/'],
+              },
+              module: {
+                manifestLocation: 'http://localhost:3000/manifest.json',
+              },
+              navigationSegments: [
+                {
+                  "segmentId": "cost-management",
+                  "navItems": [
+                      {
+                          "id": "cost-management.nav",
+                          "title": "Cost Management changed",
+                          "expandable": true,
+                          "routes": [
+                              {
+                                  "id": "cost-management.overview",
+                                  "title": "Overview changed",
+                                  "href": "/openshift/cost-management",
+                              },
+                              {
+                                  "id": "cost-management.systems",
+                                  "title": "Systems",
+                                  "href": "/openshift/cost-management/systems",
+                              },
+                          ]
+                      }
+                  ]
+                }
+              ],
+            },
+          },
+        ],
+      };
+
+      const remoteNav: Nav = costNav;
+      const result = navigationInterceptor(frontendCRD, remoteNav, bundleId);
+      const rootData = result[0].navItems?.find((item) => item.id === 'cost-management.nav');
+      expect(rootData).toBeDefined();
+      expect(rootData?.title).toEqual('Cost Management changed');
+      const rootRoutes = rootData?.routes;
+      expect(rootRoutes).toBeDefined();
+      expect(rootRoutes?.[0].title).toEqual('Overview changed');
+    });
   });
 });

packages/config-utils/src/feo/navigation-interceptor.ts

@@ -110,6 +110,9 @@ function parseNavItems(
         if (segmentItemMatch && !hasSegmentRef(segmentItemMatch)) {
           return handleNestedNav(segmentItemMatch, navItem, bSegmentCache, nSegmentCache, bundleId, currentFrontendName, parentSegment);
         }
+      } else if (typeof navItem.groupId === 'string' && navItem.groupId.length > 0) {
+        navItem.navItems = parseNavItems(navItem.navItems || [], bSegmentCache, nSegmentCache, bundleId, currentFrontendName);
+        return navItem;
       }
     }
     return navItem;

packages/config-utils/src/feo/test-nav-cost.json

@@ -0,0 +1,75 @@
+
+{
+  "id": "openshift",
+  "navItems": [
+    {
+      "bundleSegmentRef": "openshift",
+      "frontendRef": "openshift",
+      "groupId": "cluster-management",
+      "id": "cluster-management",
+      "navItems": [
+        {
+          "bundleSegmentRef": "openshift",
+          "expandable": true,
+          "frontendRef": "cost-management",
+          "id": "cost-management.nav",
+          "routes": [
+            {
+              "href": "/openshift/cost-management",
+              "id": "cost-management.overview",
+              "title": "Overview"
+            },
+            {
+              "href": "/openshift/cost-management/systems",
+              "id": "cost-management.systems",
+              "title": "Systems"
+            },
+            {
+              "href": "/openshift/cost-management/optimizations",
+              "id": "cost-management.optimizations",
+              "title": "Optimizations"
+            },
+            {
+              "href": "/openshift/cost-management/ocp",
+              "id": "cost-management.ocp",
+              "title": "OpenShift"
+            },
+            {
+              "href": "/openshift/cost-management/aws",
+              "id": "cost-management.aws",
+              "title": "Amazon Web Services"
+            },
+            {
+              "href": "/openshift/cost-management/gcp",
+              "id": "cost-management.gcp",
+              "title": "Google Cloud Platform"
+            },
+            {
+              "href": "/openshift/cost-management/azure",
+              "id": "cost-management.azure",
+              "title": "Microsoft Azure"
+            },
+            {
+              "href": "/openshift/cost-management/explorer",
+              "id": "cost-management.explorer",
+              "title": "Cost Explorer"
+            },
+            {
+              "href": "/openshift/cost-management/settings",
+              "id": "cost-management.settings",
+              "title": "Settings"
+            }
+          ],
+          "segmentRef": {
+            "frontendName": "cost-management",
+            "segmentId": "cost-management"
+          },
+          "title": "Cost Management"
+        }
+      ],
+      "position": 100,
+      "title": "Cluster Management"
+    }
+  ],
+  "title": "OpenShift"
+}