refactor: remove unused code related to bulk select all

Author: raswonders

src/components/SystemsViewTable/SystemsViewTable.tsx

@@ -23,12 +23,7 @@ import {
   ResponsiveActions,
   BulkSelect,
 } from '@patternfly/react-component-groups';
-import {
-  type System,
-  fetchAllSystems,
-  useSystemsQuery,
-} from './hooks/useSystemsQuery';
-import { useQueryClient } from '@tanstack/react-query';
+import { type System, useSystemsQuery } from './hooks/useSystemsQuery';
 import { ErrorState } from '@redhat-cloud-services/frontend-components/ErrorState';
 import SkeletonTable from '@patternfly/react-component-groups/dist/dynamic/SkeletonTable';
 import { EmptySystemsState } from './components/EmptySystemsState';
@@ -38,8 +33,6 @@ const INITIAL_PAGE = 1;
 const NO_HEADER = <></>;
 
 const SystemsViewTable: React.FC = () => {
-  const queryClient = useQueryClient();
-
   const pagination = useDataViewPagination({
     perPage: PER_PAGE,
     page: INITIAL_PAGE,
@@ -128,14 +121,6 @@ const SystemsViewTable: React.FC = () => {
           setSelected([]);
         }
         break;
-      case 'all':
-        const allSystems = await fetchAllSystems({
-          total,
-          perPage: pagination.perPage,
-          queryClient,
-        });
-        onSelect(true, allSystems.map(mapSystemToRow));
-        break;
     }
   };
 
@@ -149,7 +134,7 @@ const SystemsViewTable: React.FC = () => {
         bulkSelect={
           <BulkSelect
             pageCount={rows.length}
-            // canSelectAll disabled as we miss spinner & ability to disable controls
+            // canSelectAll disabled see JIRA: RHINENG-22312 for details
             totalCount={total}
             selectedCount={selected.length}
             pagePartiallySelected={isPagePartiallySelected(rows)}

src/components/SystemsViewTable/hooks/useSystemsQuery.ts

@@ -1,7 +1,6 @@
-import { type QueryClient, useQuery } from '@tanstack/react-query';
+import { useQuery } from '@tanstack/react-query';
 import { generateFilter } from '@redhat-cloud-services/frontend-components-utilities/helpers';
 import { getHostList, getHostTags } from '../../../api/hostInventoryApiTyped';
-import pAll from 'p-all';
 
 type FetchSystemsReturnedValue = Awaited<ReturnType<typeof fetchSystems>>;
 export type System = FetchSystemsReturnedValue['results'][number];
@@ -10,7 +9,6 @@ interface FetchSystemsParams {
   page: number;
   perPage: number;
 }
-
 const fetchSystems = async ({ page, perPage }: FetchSystemsParams) => {
   const state = { filters: { filter: {} } };
   const fields = {
@@ -54,39 +52,10 @@ const fetchSystems = async ({ page, perPage }: FetchSystemsParams) => {
   return { results, total };
 };
 
-const MAX_CONCURRENT_FETCHES = 5;
-interface FetchAllSystemsParams {
-  total?: number;
+interface UseSystemsQueryParams {
+  page: number;
   perPage: number;
-  queryClient: QueryClient;
 }
-
-export const fetchAllSystems = async ({
-  total,
-  perPage,
-  queryClient,
-}: FetchAllSystemsParams) => {
-  if (!total) return [];
-
-  const totalPages = Math.ceil(total / perPage);
-
-  const allPages = (await pAll(
-    Array.from(
-      { length: totalPages },
-      (_, i) => () =>
-        queryClient.fetchQuery({
-          queryKey: ['systems', i + 1, perPage],
-          queryFn: () => fetchSystems({ page: i + 1, perPage }),
-        }),
-    ),
-    { concurrency: MAX_CONCURRENT_FETCHES },
-  )) as FetchSystemsReturnedValue[];
-
-  return allPages.flatMap((page) => page.results);
-};
-
-type UseSystemsQueryParams = FetchSystemsParams;
-
 export const useSystemsQuery = ({ page, perPage }: UseSystemsQueryParams) => {
   const { data, isLoading, isError, error } = useQuery({
     queryKey: ['systems', page, perPage],