fix: phpstan errors (#17)

Author: GigaGiorgadze

phpstan.neon.dist

@@ -12,4 +12,8 @@ parameters:
     ignoreErrors:
         -
             identifier: missingType.iterableValue
+        -
+            identifier: property.defaultValue
+        -
+            identifier: trait.unused
 

src/Abstracts/BaseBlock.php

@@ -48,7 +48,7 @@ public static function getUrlForFile(array | string | null $path = null): ?strin
             return static::generatedStorageUrl($path);
         }
 
-        if (is_array($path) && count($path) > 0) {
+        if (count($path) > 0) {
             $filePath = array_values($path)[0];
             if (is_string($filePath)) {
                 return static::generatedStorageUrl($filePath);
@@ -98,4 +98,11 @@ public static function getBlockLabel(array $state, ?int $index = null): mixed
 
         return static::getBlockName() . ' - ' . ($index + 1);
     }
+
+    public static function getBaseBlockSchema(?object $record = null): array
+    {
+        return [
+            // schema
+        ];
+    }
 }

src/Commands/CreatePageBuilderPluginBlockCommand.php

@@ -120,7 +120,7 @@ public function handle(): int
             );
         }
 
-        if ($isGlobal && isset($isFirstGlobalBlock) && $isFirstGlobalBlock) {
+        if ($isGlobal && $isFirstGlobalBlock) {
             $this->info('To manage global blocks in Filament, add the GlobalBlocksPlugin to your panel:');
         }
 

src/Components/Forms/RadioButtonImage.php

@@ -76,6 +76,7 @@ public function getFormattedOptions(): array
         $options = collect($options);
 
         return $options->flatMap(function ($categoryOptions, $category) {
+            // @phpstan-ignore-next-line
             return collect($categoryOptions)->mapWithKeys(function ($option, $key) use ($category) {
                 return [
                     $key => [

src/Models/GlobalBlockConfig.php

@@ -5,8 +5,15 @@
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\File;
+use Redberry\PageBuilderPlugin\Abstracts\BaseBlock;
 use ReflectionClass;
 
+/**
+ * @property string $id
+ * @property string $name
+ * @property class-string<BaseBlock> $class_name
+ * @property array $configuration
+ */
 class GlobalBlockConfig extends Model
 {
     use HasFactory;

src/Resources/GlobalBlockConfigResource.php

@@ -3,6 +3,7 @@
 namespace Redberry\PageBuilderPlugin\Resources;
 
 use Filament\Forms;
+use Filament\Forms\Components\Field;
 use Filament\Forms\Form;
 use Filament\Resources\Resource;
 use Filament\Tables;
@@ -49,6 +50,8 @@ public static function form(Form $form): Form
                             }
 
                             foreach ($schema as $field) {
+                                /** @var Field $field */
+                                $field = $field;
                                 if (method_exists($field, 'getName')) {
                                     $fieldName = $field->getName();
                                     $configValue = $record->getConfigValue($fieldName);

src/Resources/GlobalBlockConfigResource/Pages/EditGlobalBlock.php

@@ -4,6 +4,7 @@
 
 use Filament\Actions;
 use Filament\Resources\Pages\EditRecord;
+use Redberry\PageBuilderPlugin\Models\GlobalBlockConfig;
 use Redberry\PageBuilderPlugin\Resources\GlobalBlockConfigResource;
 
 class EditGlobalBlock extends EditRecord
@@ -26,9 +27,11 @@ protected function getHeaderActions(): array
 
     protected function mutateFormDataBeforeFill(array $data): array
     {
-        $blockClass = $this->record->class_name;
+        /** @var GlobalBlockConfig $record */
+        $record = $this->record;
+        $blockClass = $record->class_name;
 
-        if (class_exists($blockClass) && $this->record->configuration) {
+        if (class_exists($blockClass) && $record->configuration) {
             try {
                 if (method_exists($blockClass, 'getBaseBlockSchema')) {
                     $schema = $blockClass::getBaseBlockSchema();
@@ -39,7 +42,7 @@ protected function mutateFormDataBeforeFill(array $data): array
                 foreach ($schema as $field) {
                     if (method_exists($field, 'getName')) {
                         $fieldName = $field->getName();
-                        $configValue = $this->record->getConfigValue($fieldName);
+                        $configValue = $record->getConfigValue($fieldName);
                         if ($configValue !== null) {
                             $data[$fieldName] = $configValue;
                         }
@@ -55,7 +58,9 @@ protected function mutateFormDataBeforeFill(array $data): array
     protected function mutateFormDataBeforeSave(array $data): array
     {
         $configuration = [];
-        $blockClass = $this->record->class_name;
+        /** @var GlobalBlockConfig $record */
+        $record = $this->record;
+        $blockClass = $record->class_name;
 
         if (class_exists($blockClass)) {
             try {