fix: re-index state array after block deletion to prevent undefined k… (#21)

* fix: re-index state array after block deletion to prevent undefined key error

* ci: update php version in ci

* fix: testbench package issue

* fix: update test bench version to working one'

---------

Co-authored-by: GigaGiorgadze <giga.giorgadze.11@gmail.com>

Author: Davitamgl

.github/workflows/phpstan.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '8.1'
+          php-version: '8.3'
           coverage: none
 
       - name: Install composer dependencies

composer.json

@@ -31,7 +31,7 @@
         "laravel/pint": "^1.0",
         "nunomaduro/collision": "^7.9||^8.0",
         "nunomaduro/larastan": "^2.0.1||^3.0",
-        "orchestra/testbench": "^10.0.0||^9.0||^8.35",
+        "orchestra/testbench": "^10.0.0||^9.16||^8.35",
         "pestphp/pest": "^3.1||^2.0",
         "pestphp/pest-plugin-arch": "^3.0||^2.0",
         "pestphp/pest-plugin-laravel": "^3.0||^2.0",
@@ -78,4 +78,4 @@
     },
     "minimum-stability": "dev",
     "prefer-stable": true
-}
+}

src/Components/Forms/Actions/DeletePageBuilderBlockAction.php

@@ -43,7 +43,7 @@ protected function setUp(): void
             $items = $component->getState();
             unset($items[$arguments['index']]);
 
-            $component->state($items);
+            $component->state(array_values($items));
 
             $action->sendSuccessNotification();
 

tests/Forms/PageBuilderTest.php

@@ -122,6 +122,49 @@
         ]);
 });
 
+it('can delete multiple blocks sequentially without undefined array key error', function () {
+    $blocks = PageBuilderBlock::factory()->count(2)->sequence(
+        ['order' => 0],
+        ['order' => 1],
+    )->create([
+        'block_type' => ViewBlock::class,
+        'page_builder_blockable_id' => $this->page->id,
+        'page_builder_blockable_type' => Page::class,
+        'data' => [
+            'image' => 'https://example.com/image.jpg',
+            'hero_button' => [
+                'text' => 'Test',
+                'url' => 'https://example.com',
+            ],
+        ],
+    ]);
+
+    $component = livewire(TestComponentWithPageBuilderRenderedUsingViews::class);
+
+    // Delete the first block (index 0)
+    $component
+        ->mountFormComponentAction('website_content', 'delete', ['index' => 0, 'item' => $blocks->get(0)->id])
+        ->callMountedFormComponentAction()
+        ->assertHasNoErrors()
+        ->assertFormSet([
+            'website_content' => [
+                [
+                    'id' => $blocks->get(1)->id,
+                ],
+            ],
+        ]);
+
+    // Delete the second block — now also at index 0 after re-indexing.
+    // This used to throw "Undefined array key 0".
+    $component
+        ->mountFormComponentAction('website_content', 'delete', ['index' => 0, 'item' => $blocks->get(1)->id])
+        ->callMountedFormComponentAction()
+        ->assertHasNoErrors()
+        ->assertFormSet([
+            'website_content' => [],
+        ]);
+});
+
 it('can reorder existing blocks', function () {
     $blocks = PageBuilderBlock::factory()->count(3)->sequence(
         [