page size handling

Author: MaestroError

src/SDK/Requests/Actions/BlockChildren.php

@@ -19,7 +19,7 @@ public function resolveEndpoint(): string
 
     public function __construct(
         protected string $id,
-        protected ?string $pageSize = null,
+        protected ?int $pageSize = null,
     ) {}
 
     public function defaultQuery(): array

src/SDK/Requests/Actions/QueryDataSource.php

@@ -20,8 +20,17 @@ public function resolveEndpoint(): string
     public function __construct(
         protected string $dataSourceId,
         protected ?array $filter = null,
+        protected ?int $pageSize = null,
     ) {}
 
+    protected function defaultBody(): array
+    {
+        return array_filter([
+            'filter' => $this->filter,
+            'page_size' => $this->pageSize,
+        ]);
+    }
+
     // Potentially it can have a filter object in the body
     // @todo create separate request with filter, use this to fetch all items
 }

src/SDK/Resource/Actions.php

@@ -18,7 +18,7 @@ public function getPage(string $id): Response
         return $this->connector->send(new Page($id));
     }
 
-    public function getBlockChildren(string $id, ?string $pageSize): Response
+    public function getBlockChildren(string $id, ?int $pageSize = null): Response
     {
         return $this->connector->send(new BlockChildren($id, $pageSize));
     }
@@ -38,8 +38,8 @@ public function listComments(?string $blockId): Response
         return $this->connector->send(new ListComments($blockId));
     }
 
-    public function queryDataSource(string $dataSourceId, ?array $filter = null): Response
+    public function queryDataSource(string $dataSourceId, ?array $filter = null, ?int $pageSize = null): Response
     {
-        return $this->connector->send(new QueryDataSource($dataSourceId, $filter));
+        return $this->connector->send(new QueryDataSource($dataSourceId, $filter, $pageSize));
     }
 }

src/Services/DatabaseReader.php

@@ -18,22 +18,26 @@ public function __construct(
      * Read database content and build complete Database object
      *
      * @param  string  $databaseId  The Notion database ID
+     * @param  int|null  $pageSize  Optional page size for data source query (uses config default if null)
      * @return Database The database object with all content and items
      */
-    public function read(string $databaseId): Database
+    public function read(string $databaseId, ?int $pageSize = null): Database
     {
         // Get database details and build initial Database object
         $databaseResponse = $this->sdk->act()->getDatabase($databaseId);
         $databaseData = $databaseResponse->json();
         $database = Database::from($databaseData);
 
+        // Resolve page size from argument or config default
+        $resolvedPageSize = $pageSize ?? config('md-notion.default_page_size');
+
         // Query database data source only once
         if (isset($databaseData['data_sources']) && is_array($databaseData['data_sources'])) {
             foreach ($databaseData['data_sources'] as $dataSource) {
                 $dataSourceId = $dataSource['id'] ?? null;
                 if ($dataSourceId) {
                     // Query the data source to get its content
-                    $queryResponse = $this->sdk->act()->queryDataSource($dataSourceId, null);
+                    $queryResponse = $this->sdk->act()->queryDataSource($dataSourceId, null, $resolvedPageSize);
                     $queryData = $queryResponse->json();
                     // Convert query data to markdown table
                     $tableContent = $this->databaseTable->convertQueryToMarkdownTable($queryData);

src/Services/PageReader.php

@@ -17,17 +17,19 @@ public function __construct(
      * Read page content and build complete Page object
      *
      * @param  string  $pageId  The Notion page ID
+     * @param  int|null  $pageSize  Optional page size for block children (uses config default if null)
      * @return Page The page object with all content and children
      */
-    public function read(string $pageId): Page
+    public function read(string $pageId, ?int $pageSize = null): Page
     {
         // Get page details and build initial Page object
         $pageResponse = $this->sdk->act()->getPage($pageId);
         $pageData = $pageResponse->json();
         $page = Page::from($pageData);
 
         // Get block children only once
-        $blocksResponse = $this->sdk->act()->getBlockChildren($pageId, null);
+        $resolvedPageSize = $pageSize ?? config('md-notion.default_page_size');
+        $blocksResponse = $this->sdk->act()->getBlockChildren($pageId, $resolvedPageSize);
         $blocks = $blocksResponse->json()['results'] ?? [];
 
         // Process blocks to extract different types of content

tests/SDK/Requests/BlockChildrenRequestTest.php

@@ -24,7 +24,7 @@
 
 test('it can set page size query parameter', function () {
     $blockId = '263d9316-605a-8057-b12e-f880bc565fcb';
-    $pageSize = '25';
+    $pageSize = 25;
     $request = new BlockChildren($blockId, $pageSize);
 
     expect($request->query()->all())->toBe(['page_size' => $pageSize]);