Add svs submodule (#621)

* Add svs submodule

* use recursive checkouts

Author: alonre24

.github/workflows/benchmark-runner.yml

@@ -49,6 +49,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.number && format('refs/pull/{0}/merge', github.event.number) || github.head_ref }}
+          submodules: recursive
       - name: Print runner info
         run: |
           printf "Runner lscpu:\n$(lscpu)\n"

.github/workflows/coverage.yml

@@ -36,6 +36,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.number && format('refs/pull/{0}/merge', github.event.number) || github.head_ref }}
+          submodules: recursive
       - name: install dependencies
         run: sudo .install/install_script.sh
       - name: run codecov

.github/workflows/event-pull_request.yml

@@ -17,6 +17,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.number && format('refs/pull/{0}/merge', github.event.number) || github.head_ref }}
+          submodules: recursive
       - name: setup python
         uses: actions/setup-python@v5
         with:

.github/workflows/task-unit-test.yml

@@ -35,6 +35,7 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.number && format('refs/pull/{0}/merge', github.event.number) || github.head_ref }}
+          submodules: recursive
       - name: install dependencies
         run: .install/install_script.sh ${{ !inputs.container && 'sudo' || '' }}
       - name: Set Artifact Name

.gitignore

@@ -6,7 +6,6 @@
 /build/
 /dist/
 /venv/
-/deps/
 /1/
 **/build/
 

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "deps/ScalableVectorSearch"]
+	path = deps/ScalableVectorSearch
+	url = https://github.com/intel/ScalableVectorSearch.git

CMakeLists.txt

@@ -4,12 +4,10 @@ cmake_policy(SET CMP0077 NEW)
 set(CMAKE_CXX_STANDARD 20)
 option(VECSIM_BUILD_TESTS "Build tests" ON)
 
-# option(VECSIM_STATIC "Build as static library" OFF)
 get_filename_component(root ${CMAKE_CURRENT_LIST_DIR} ABSOLUTE)
 message("# VectorSimilarity root: " ${root})
 get_filename_component(binroot ${CMAKE_CURRENT_BINARY_DIR} ABSOLUTE)
 message("# VectorSimilarity binroot: " ${binroot})
-message("# VectorSimilarity static build: " ${VECSIM_STATIC})
 
 if(USE_COVERAGE)
 	if(NOT CMAKE_BUILD_TYPE STREQUAL "DEBUG")
@@ -73,13 +71,9 @@ if(VECSIM_BUILD_TESTS)
 	endif()
 endif()
 
+add_subdirectory(deps/ScalableVectorSearch)
 add_subdirectory(src/VecSim)
 
 # Needed for build as ExternalProject (like RediSearch does)
 install(TARGETS VectorSimilarity DESTINATION ${CMAKE_INSTALL_PREFIX})
 install(TARGETS VectorSimilaritySpaces DESTINATION ${CMAKE_INSTALL_PREFIX})
-
-# if(NOT VECSIM_STATIC)
-# set_target_properties(VectorSimilarity PROPERTIES PREFIX "lib")
-# set_target_properties(VectorSimilarity PROPERTIES SUFFIX ".so")
-# endif()