add assert storage_blob == nullptr || input_blob_size == processed_bytes_count

add valgrind macro

value_to_add of DummyQueryPreprocessor and DummyMixedPreprocessor is now DataType instead of int

Author: meiravgri

Makefile

@@ -177,6 +177,7 @@ ifeq ($(VALGRIND),1)
 _CTEST_ARGS += \
 	-T memcheck \
 	--overwrite MemoryCheckCommandOptions="--leak-check=full --fair-sched=yes --error-exitcode=255"
+CMAKE_FLAGS += -DUSE_VALGRIND=ON
 endif
 
 unit_test:

src/VecSim/spaces/computer/preprocessors.h

@@ -44,18 +44,25 @@ class PreprocessorInterface : public VecsimBaseObject {
 template <typename DataType>
 class CosinePreprocessor : public PreprocessorInterface {
 public:
-    // This preprocessor assumes storage_blob and query_blob
-    // both are preprocessed in the same way, and yield a blob in the same size.
+    // This preprocessor requires that storage_blob and query_blob have identical memory sizes
+    // both before processing (as input) and after preprocessing completes.
     CosinePreprocessor(std::shared_ptr<VecSimAllocator> allocator, size_t dim,
                        size_t processed_bytes_count)
         : PreprocessorInterface(allocator), normalize_func(spaces::GetNormalizeFunc<DataType>()),
           dim(dim), processed_bytes_count(processed_bytes_count) {}
 
-    // If a blob (storage_blob or query_blob) is not nullptr, it means a previous preprocessor
-    // already allocated and processed it. So, we process it inplace. If it's null, we need to
-    // allocate memory for it and copy the original_blob to it.
     void preprocess(const void *original_blob, void *&storage_blob, void *&query_blob,
                     size_t &input_blob_size, unsigned char alignment) const override {
+        // This assert verifies that if a blob was allocated by a previous preprocessor, its
+        // size matches our expected processed size. Therefore, it is safe to skip re-allocation and
+        // process it inplace. Supporting dynamic resizing would require additional size checks (if
+        // statements) and memory management logic, which could impact performance. Currently, no
+        // code path requires this capability. If resizing becomes necessary in the future, remove
+        // the assertions and implement appropriate allocation handling with performance
+        // considerations.
+        assert(storage_blob == nullptr || input_blob_size == processed_bytes_count);
+        assert(query_blob == nullptr || input_blob_size == processed_bytes_count);
+
         // Case 1: Blobs are different (one might be null, or both are allocated and processed
         // separately).
         if (storage_blob != query_blob) {
@@ -87,6 +94,9 @@ class CosinePreprocessor : public PreprocessorInterface {
 
     void preprocessForStorage(const void *original_blob, void *&blob,
                               size_t &input_blob_size) const override {
+        // see assert docs in preprocess
+        assert(blob == nullptr || input_blob_size == processed_bytes_count);
+
         if (blob == nullptr) {
             blob = this->allocator->allocate(processed_bytes_count);
             memcpy(blob, original_blob, input_blob_size);
@@ -97,6 +107,8 @@ class CosinePreprocessor : public PreprocessorInterface {
 
     void preprocessQuery(const void *original_blob, void *&blob, size_t &input_blob_size,
                          unsigned char alignment) const override {
+        // see assert docs in preprocess
+        assert(blob == nullptr || input_blob_size == processed_bytes_count);
         if (blob == nullptr) {
             blob = this->allocator->allocate_aligned(processed_bytes_count, alignment);
             memcpy(blob, original_blob, input_blob_size);

tests/unit/CMakeLists.txt

@@ -28,6 +28,12 @@ if(FP64_TESTS)
 	add_definitions(-DFP64_TESTS)
 endif()
 
+option(USE_VALGRIND "Building for Valgrind" OFF)
+if(USE_VALGRIND)
+    add_definitions(-DRUNNING_ON_VALGRIND)
+    message(STATUS "Building with RUNNING_ON_VALGRIND definition for Valgrind compatibility")
+endif()
+
 if (CMAKE_HOST_SYSTEM_PROCESSOR MATCHES "(aarch64)|(arm64)|(ARM64)|(armv8)|(armv9)")
 	include(${root}/cmake/aarch64InstructionFlags.cmake)
 else()