MOD-9909 Make CLUSTERSET visible again (#61)

Redis 8 introduced a new "internal" module flag which can be used to hide internal commands from COMMAND LIST.
We need CLUSTERSET to remain visible in order for the cluster to identify a module as cluster-aware and update it upon topology changes, so this fix removed the "internal" flag from this specific command.

Author: galcohen-redislabs

src/cluster.c

@@ -1365,8 +1365,11 @@ int MR_ClusterInit(RedisModuleCtx* rctx, char *password) {
         }
     }
 
+    /* The CLUSTERSET should be visible in COMMAND LIST, otherwise the RAMP packer
+     * will miss it and a module will not be notified in an enterprise cluster */
     if (!RegisterRedisCommand(rctx, CLUSTER_SET_COMMAND, MR_ClusterSet,
-                            command_flags, 0, 0, -1)) {
+                            MR_IsEnterpriseBuild() ? "readonly deny-script _proxy-filtered" : "readonly deny-script",
+                            0, 0, -1)) {
         return REDISMODULE_ERR;
     }
 

tests/mr_test_module/pytests/run_tests.sh

@@ -19,4 +19,4 @@ else
 fi
 
 
-python3 -m RLTest --verbose-information-on-failure --module $MODULE_PATH --clear-logs "$@" --oss_password "password" --enable-debug-command
+python3 -m RLTest --verbose-information-on-failure --no-progress --module $MODULE_PATH --clear-logs "$@" --oss_password "password" --enable-debug-command

tests/mr_test_module/pytests/test_basic.py

@@ -82,7 +82,6 @@ def testRemoteTaskOnAllShards(env, conn):
 
 @MRTestDecorator(skipOnVersionLowerThan='8.0.0', skipOnCluster=False)
 def testInternalCommandsAreNotAllowed(env, conn):
-    env.expect('MRTESTS.CLUSTERSET').error().contains('unknown command')
     env.expect('MRTESTS.INNERCOMMUNICATION').error().contains('unknown command')
     env.expect('MRTESTS.HELLO').error().contains('unknown command')
     env.expect('MRTESTS.CLUSTERSETFROMSHARD').error().contains('unknown command')