refactor - rename from error to exception. added JDoc

Author: DvirDukhan

src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphCompileTimeError.java

@@ -0,0 +1,21 @@
+package com.redislabs.redisgraph.exceptions;
+
+import redis.clients.jedis.exceptions.JedisDataException;
+
+/**
+ * RedisGraph query syntax evaluation exception. An instance of JRedisGraphRunTimeException is thrown when RedisGraph
+ * encounters an error during query syntax evaluation.
+ */
+public class JRedisGraphCompileTimeException extends JedisDataException {
+    public JRedisGraphCompileTimeException(String message) {
+        super(message);
+    }
+
+    public JRedisGraphCompileTimeException(Throwable cause) {
+        super(cause);
+    }
+
+    public JRedisGraphCompileTimeException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphCompileTimeException.java

@@ -0,0 +1,21 @@
+package com.redislabs.redisgraph.exceptions;
+
+import redis.clients.jedis.exceptions.JedisDataException;
+
+/**
+ * RedisGraph runtime exception. An instance of JRedisGraphRunTimeException is thrown when RedisGraph
+ * encounters a runtime error during query execution.
+ */
+public class JRedisGraphRunTimeException extends JedisDataException {
+    public JRedisGraphRunTimeException(String message) {
+        super(message);
+    }
+
+    public JRedisGraphRunTimeException(Throwable cause) {
+        super(cause);
+    }
+
+    public JRedisGraphRunTimeException(String message, Throwable cause) {
+        super(message, cause);
+    }
+}

src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphRunTimeError.java

@@ -2,8 +2,8 @@
 
 import com.redislabs.redisgraph.RedisGraphContext;
 import com.redislabs.redisgraph.ResultSet;
-import com.redislabs.redisgraph.exceptions.JRedisGraphCompileTimeError;
-import com.redislabs.redisgraph.exceptions.JRedisGraphRunTimeError;
+import com.redislabs.redisgraph.exceptions.JRedisGraphCompileTimeException;
+import com.redislabs.redisgraph.exceptions.JRedisGraphRunTimeException;
 import com.redislabs.redisgraph.impl.Utils;
 import com.redislabs.redisgraph.impl.graph_cache.RedisGraphCaches;
 import com.redislabs.redisgraph.impl.resultset.ResultSetImpl;
@@ -52,11 +52,11 @@ protected ResultSet sendQuery(String graphId, String preparedQuery) {
             List<Object> rawResponse = (List<Object>) conn.sendCommand(RedisGraphCommand.QUERY, graphId, preparedQuery, Utils.COMPACT_STRING);
             return new ResultSetImpl(rawResponse, this, caches.getGraphCache(graphId));
         }
-        catch (JRedisGraphRunTimeError rt) {
+        catch (JRedisGraphRunTimeException rt) {
             throw rt;
         }
         catch (JedisDataException j) {
-            throw new JRedisGraphCompileTimeError(j);
+            throw new JRedisGraphCompileTimeException(j);
         }
     }
 

src/main/java/com/redislabs/redisgraph/exceptions/JRedisGraphRunTimeException.java

@@ -5,7 +5,7 @@
 import com.redislabs.redisgraph.RedisGraph;
 import com.redislabs.redisgraph.ResultSet;
 import com.redislabs.redisgraph.Statistics;
-import com.redislabs.redisgraph.exceptions.JRedisGraphRunTimeError;
+import com.redislabs.redisgraph.exceptions.JRedisGraphRunTimeException;
 import com.redislabs.redisgraph.graph_entities.Edge;
 import com.redislabs.redisgraph.graph_entities.GraphEntity;
 import com.redislabs.redisgraph.graph_entities.Node;
@@ -41,7 +41,7 @@ public ResultSetImpl(List<Object> rawResponse, RedisGraph redisGraph, GraphCache
         // If a run-time error occured, the last member of the rawResponse will be a JedisDataException.
         if (rawResponse.get(rawResponse.size()-1) instanceof JedisDataException) {
 
-            throw new JRedisGraphRunTimeError((Throwable) rawResponse.get(rawResponse.size() - 1));
+            throw new JRedisGraphRunTimeException((Throwable) rawResponse.get(rawResponse.size() - 1));
         }
 
         if (rawResponse.size() != 3) {

src/main/java/com/redislabs/redisgraph/impl/api/ContextedRedisGraph.java

@@ -32,7 +32,7 @@ public void deleteGraph() {
 
     @Test
     public void testSyntaxErrorReporting() {
-        exceptionRule.expect(JRedisGraphCompileTimeError.class);
+        exceptionRule.expect(JRedisGraphCompileTimeException.class);
         exceptionRule.expectMessage("Type mismatch: expected String but was Integer");
 
         // Issue a query that causes a compile-time error
@@ -42,7 +42,7 @@ public void testSyntaxErrorReporting() {
 
     @Test
     public void testRuntimeErrorReporting() {
-        exceptionRule.expect(JRedisGraphRunTimeError.class);
+        exceptionRule.expect(JRedisGraphRunTimeException.class);
         exceptionRule.expectMessage("Type mismatch: expected String but was Integer");
 
         // Issue a query that causes a run-time error
@@ -57,7 +57,7 @@ public void testExceptionFlow() {
             api.query("social", "RETURN toUpper(5)");
         }
         catch (Exception e) {
-            Assert.assertEquals(JRedisGraphCompileTimeError.class, e.getClass());
+            Assert.assertEquals(JRedisGraphCompileTimeException.class, e.getClass());
             Assert.assertTrue( e.getMessage().contains("Type mismatch: expected String but was Integer"));
         }
 
@@ -68,7 +68,7 @@ public void testExceptionFlow() {
             api.query("social", "MATCH (p:person) RETURN toUpper(p.mixed_prop)");
         }
         catch (Exception e) {
-            Assert.assertEquals(JRedisGraphRunTimeError.class, e.getClass());
+            Assert.assertEquals(JRedisGraphRunTimeException.class, e.getClass());
             Assert.assertTrue( e.getMessage().contains("Type mismatch: expected String but was Integer"));
         }
 
@@ -77,7 +77,7 @@ public void testExceptionFlow() {
 
     @Test
     public void testContextSyntaxErrorReporting() {
-        exceptionRule.expect(JRedisGraphCompileTimeError.class);
+        exceptionRule.expect(JRedisGraphCompileTimeException.class);
         exceptionRule.expectMessage("Type mismatch: expected String but was Integer");
         RedisGraphContext c = api.getContext();
 
@@ -88,7 +88,7 @@ public void testContextSyntaxErrorReporting() {
 
     @Test
     public void testContextRuntimeErrorReporting() {
-        exceptionRule.expect(JRedisGraphRunTimeError.class);
+        exceptionRule.expect(JRedisGraphRunTimeException.class);
         exceptionRule.expectMessage("Type mismatch: expected String but was Integer");
 
         RedisGraphContext c = api.getContext();
@@ -97,8 +97,6 @@ public void testContextRuntimeErrorReporting() {
     }
 
 
-
-
     @Test
     public void testContextExceptionFlow() {
 
@@ -108,7 +106,7 @@ public void testContextExceptionFlow() {
             c.query("social", "RETURN toUpper(5)");
         }
         catch (Exception e) {
-            Assert.assertEquals(JRedisGraphCompileTimeError.class, e.getClass());
+            Assert.assertEquals(JRedisGraphCompileTimeException.class, e.getClass());
             Assert.assertTrue( e.getMessage().contains("Type mismatch: expected String but was Integer"));
         }
 
@@ -119,11 +117,9 @@ public void testContextExceptionFlow() {
             c.query("social", "MATCH (p:person) RETURN toUpper(p.mixed_prop)");
         }
         catch (Exception e) {
-            Assert.assertEquals(JRedisGraphRunTimeError.class, e.getClass());
+            Assert.assertEquals(JRedisGraphRunTimeException.class, e.getClass());
             Assert.assertTrue( e.getMessage().contains("Type mismatch: expected String but was Integer"));
         }
 
     }
-
-
-}
+}