Skip to content

Commit ca8d001

Browse files
author
DvirDukhan
committed
removed Jedis try resource block - move to try catch
1 parent 3bf901f commit ca8d001

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

src/main/java/com/redislabs/redisgraph/RedisGraph.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,22 @@ public ResultSet query(String graphId, String query, Object ...args) {
8989
query = String.format(query, args);
9090
}
9191
graphCaches.putIfAbsent(graphId, new GraphCache(graphId, this));
92-
93-
try (Jedis conn = getConnection()) {
94-
List<Object> rawResponsw = sendCompactCommand(conn, Command.QUERY, graphId, query).getObjectMultiBulkReply();
92+
Jedis conn = null;
93+
List<Object> rawResponse = new ArrayList<Object>();
94+
try {
95+
conn = getConnection();
96+
rawResponse= sendCompactCommand(conn, Command.QUERY, graphId, query).getObjectMultiBulkReply();
9597
conn.close();
96-
return new ResultSetImpl(rawResponsw, graphCaches.get(graphId));
97-
}
98-
catch (Exception e){
99-
// e.printStackTrace();
100-
return new ResultSetImpl(new ArrayList<Object>(), graphCaches.get(graphId));
98+
99+
} catch (Exception e) {
100+
e.printStackTrace();
101+
if(conn != null && conn.isConnected()){
102+
conn.close();
103+
throw e;
104+
}
101105
}
106+
return new ResultSetImpl(rawResponse, graphCaches.get(graphId));
107+
102108
}
103109

104110
/**

src/test/java/com/redislabs/redisgraph/RedisGraphAPITest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,8 +296,9 @@ public void tinyTestMultiThread(){
296296
ResultSet resultSet = api.query("social", "CREATE ({name:'roi',age:32})");
297297
api.query("social", "MATCH (a:person) RETURN a");
298298
for (int i =0; i < 10000; i++){
299-
List<ResultSet> resultSets = IntStream.range(0,10).parallel().
300-
mapToObj(j-> api.query("social", "MATCH (a:person) RETURN a")).
299+
List<ResultSet> resultSets = IntStream.range(0,16).parallel().
300+
mapToObj(
301+
j-> api.query("social", "MATCH (a:person) RETURN a")).
301302
collect(Collectors.toList());
302303

303304
}
@@ -309,7 +310,7 @@ public void testMultiThread(){
309310

310311
Assert.assertNotNull(api.query("social", "CREATE (:person {name:'roi', age:32})-[:knows]->(:person {name:'amit',age:30}) "));
311312

312-
List<ResultSet> resultSets = IntStream.range(0,10).parallel().
313+
List<ResultSet> resultSets = IntStream.range(0,16).parallel().
313314
mapToObj(i-> api.query("social", "MATCH (a:person)-[r:knows]->(b:person) RETURN a,r, a.age")).
314315
collect(Collectors.toList());
315316

@@ -372,7 +373,7 @@ public void testMultiThread(){
372373
Assert.assertNotNull(api.query("social", "CREATE (:worker{lastName:'b'})"));
373374
Assert.assertNotNull(api.query("social", "MATCH (a:worker), (b:worker) WHERE (a.lastName = 'a' AND b.lastName='b') CREATE (a)-[:worksWith]->(b)"));
374375

375-
resultSets = IntStream.range(0,10).parallel().
376+
resultSets = IntStream.range(0,16).parallel().
376377
mapToObj(i-> api.query("social", "MATCH (a:worker)-[r:worksWith]->(b:worker) RETURN a,r")).
377378
collect(Collectors.toList());
378379

0 commit comments

Comments
 (0)