fix: remove qpf module hardcoded validation

Author: burythehammer

provider/pro/resource_rediscloud_pro_subscription.go

@@ -25,15 +25,6 @@ import (
 
 const CMK_ENABLED_STRING = "customer-managed-key"
 
-func containsModule(modules []interface{}, requiredModule string) bool {
-	for _, m := range modules {
-		if mod, ok := m.(string); ok && mod == requiredModule {
-			return true
-		}
-	}
-	return false
-}
-
 func ResourceRedisCloudProSubscription() *schema.Resource {
 	return &schema.Resource{
 
@@ -48,28 +39,6 @@ func ResourceRedisCloudProSubscription() *schema.Resource {
 				return nil
 			}
 
-			// Validate "query_performance_factor" dependency on "modules"
-			creationPlan := diff.Get("creation_plan").([]interface{})
-			if len(creationPlan) > 0 {
-				plan := creationPlan[0].(map[string]interface{})
-
-				qpf, qpfExists := plan["query_performance_factor"].(string)
-
-				// Ensure "modules" key is explicitly defined in HCL
-				_, modulesExists := diff.GetOkExists("creation_plan.0.modules")
-
-				if qpfExists && qpf != "" {
-					if !modulesExists {
-						return fmt.Errorf(`"query_performance_factor" requires the "modules" key to be explicitly defined in HCL`)
-					}
-
-					modules, _ := plan["modules"].([]interface{})
-					if !containsModule(modules, "RediSearch") {
-						return fmt.Errorf(`"query_performance_factor" requires the "modules" list to contain "RediSearch"`)
-					}
-				}
-			}
-
 			err := cloudRegionsForceNewDiff(ctx, diff, meta)
 			if err != nil {
 				return err

provider/resource_rediscloud_pro_subscription_qpf_test.go

@@ -109,26 +109,6 @@ func TestAccResourceRedisCloudProSubscription_qpf(t *testing.T) {
 	})
 }
 
-func TestAccResourceRedisCloudProSubscription_missingModule(t *testing.T) {
-	name := acctest.RandomWithPrefix(testResourcePrefix)
-	password := acctest.RandString(20)
-	testCloudAccountName := os.Getenv("AWS_TEST_CLOUD_ACCOUNT_NAME")
-
-	config := formatDatabaseConfig(name, testCloudAccountName, password, "4x", "")
-
-	testSubErrorCase(t, config, regexp.MustCompile("query_performance_factor\" requires the \"modules\" key to be explicitly defined in HCL"))
-}
-
-func TestAccResourceRedisCloudProSubscription_missingRediSearchModule(t *testing.T) {
-	name := acctest.RandomWithPrefix(testResourcePrefix)
-	password := acctest.RandString(20)
-	testCloudAccountName := os.Getenv("AWS_TEST_CLOUD_ACCOUNT_NAME")
-
-	config := formatDatabaseConfig(name, testCloudAccountName, password, "4x", `modules = [{ name = "RediBloom" }]`)
-
-	testSubErrorCase(t, config, regexp.MustCompile("query_performance_factor\" requires the \"modules\" list to contain \"RediSearch"))
-}
-
 func TestAccResourceRedisCloudProSubscription_invalidQueryPerformanceFactors(t *testing.T) {
 	name := acctest.RandomWithPrefix("tf-test")
 	password := acctest.RandString(20)