fix: fixing issues with the payment_method_id check

Author: burythehammer

.github/workflows/terraform_provider_pr.yml

@@ -123,7 +123,8 @@ jobs:
       - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudEssentialsSubscription"'
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudEssentialsDatabase_CRUDI"'
+
 
   go_test_smoke_essentials_sub:
     name: go test smoke essentials sub
@@ -134,7 +135,7 @@ jobs:
       - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudEssentialsSubscription_CRUDI"'
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudEssentialsSubscription"'
 
 
   go_test_smoke_pro_db:

provider/resource_rediscloud_essentials_subscription.go

@@ -91,10 +91,12 @@ func resourceRedisCloudEssentialsSubscriptionCreate(ctx context.Context, d *sche
 	}
 
 	// payment_method_id only matters if it is a credit card
-	if d.Get("payment_method").(string) != "credit-card" {
-		if d.Get("payment_method_id") != nil {
-			return diag.FromErr(errors.New("payment methods aside from credit-card cannot have a payment ID"))
-		}
+	if d.Get("payment_method").(string) != "credit-card" && d.Get("payment_method_id") != 0 {
+		return diag.FromErr(errors.New("payment methods aside from credit-card cannot have a payment ID"))
+	}
+
+	if v, ok := d.GetOk("payment_method"); ok {
+		createSubscriptionRequest.PaymentMethod = redis.String(v.(string))
 	}
 
 	if v, ok := d.GetOk("payment_method_id"); ok {