test: add fast fail to essentials subscriptions

Author: burythehammer

provider/rediscloud_essentials_subscription_test.go

@@ -4,19 +4,36 @@ import (
 	"context"
 	"flag"
 	"fmt"
+	"regexp"
+	"strconv"
+	"testing"
+
 	"github.com/RedisLabs/rediscloud-go-api/redis"
-	client2 "github.com/RedisLabs/terraform-provider-rediscloud/provider/client"
+	"github.com/RedisLabs/terraform-provider-rediscloud/provider/client"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
-	"regexp"
-	"strconv"
-	"testing"
 )
 
 var essentialsMarketplaceFlag = flag.Bool("essentialsMarketplace", false,
 	"Add this flag '-essentialsMarketplace' to run tests for marketplace associated accounts")
 
+// testAccPreCheckEssentialsSubscription checks if an essentials subscription already exists
+// and fails fast to avoid the test failing after provisioning attempts
+func testAccPreCheckEssentialsSubscription(t *testing.T) {
+	testAccPreCheck(t)
+
+	apiClient := testProvider.Meta().(*client.ApiClient)
+	subs, err := apiClient.Client.FixedSubscriptions.List(context.TODO())
+	if err != nil {
+		t.Fatalf("Failed to list essentials subscriptions: %v", err)
+	}
+
+	if len(subs) > 0 {
+		t.Skipf("Essentials subscription already exists (ID: %d). Redis Cloud allows only 1 essentials subscription per account. Please delete the existing subscription before running this test.", redis.IntValue(subs[0].ID))
+	}
+}
+
 func TestAccResourceRedisCloudEssentialsSubscription_Free_CRUDI(t *testing.T) {
 
 	testAccRequiresEnvVar(t, "EXECUTE_TESTS")
@@ -28,7 +45,7 @@ func TestAccResourceRedisCloudEssentialsSubscription_Free_CRUDI(t *testing.T) {
 	const datasourceName = "data.rediscloud_essentials_subscription.example"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
+		PreCheck:          func() { testAccPreCheckEssentialsSubscription(t) },
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCheckEssentialsSubscriptionDestroy,
 		Steps: []resource.TestStep{
@@ -93,7 +110,7 @@ func TestAccResourceRedisCloudEssentialsSubscription_Paid_CreditCard_CRUDI(t *te
 	const datasourceName = "data.rediscloud_essentials_subscription.example"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
+		PreCheck:          func() { testAccPreCheckEssentialsSubscription(t) },
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCheckEssentialsSubscriptionDestroy,
 		Steps: []resource.TestStep{
@@ -159,7 +176,7 @@ func TestAccResourceRedisCloudEssentialsSubscription_Paid_NoPaymentType_CRUDI(t
 	const datasourceName = "data.rediscloud_essentials_subscription.example"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
+		PreCheck:          func() { testAccPreCheckEssentialsSubscription(t) },
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCheckEssentialsSubscriptionDestroy,
 		Steps: []resource.TestStep{
@@ -230,7 +247,7 @@ func TestAccResourceRedisCloudEssentialsSubscription_Paid_Marketplace_CRUDI(t *t
 	const datasourceName = "data.rediscloud_essentials_subscription.example"
 
 	resource.Test(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
+		PreCheck:          func() { testAccPreCheckEssentialsSubscription(t) },
 		ProviderFactories: providerFactories,
 		CheckDestroy:      testAccCheckEssentialsSubscriptionDestroy,
 		Steps: []resource.TestStep{
@@ -414,7 +431,7 @@ data "rediscloud_essentials_subscription" "example" {
 `
 
 func testAccCheckEssentialsSubscriptionDestroy(s *terraform.State) error {
-	client := testProvider.Meta().(*client2.ApiClient)
+	apiClient := testProvider.Meta().(*client.ApiClient)
 
 	for _, r := range s.RootModule().Resources {
 		if r.Type != "rediscloud_essentials_subscription" {
@@ -426,7 +443,7 @@ func testAccCheckEssentialsSubscriptionDestroy(s *terraform.State) error {
 			return err
 		}
 
-		subs, err := client.Client.FixedSubscriptions.List(context.TODO())
+		subs, err := apiClient.Client.FixedSubscriptions.List(context.TODO())
 		if err != nil {
 			return err
 		}