Update rediscloud_subscription_database.md (#323)

Documentation adjustments

Author: noham14

docs/resources/rediscloud_subscription_database.md

@@ -21,9 +21,9 @@ data "rediscloud_cloud_account" "account" {
   provider_type = "AWS"
 }
 
-resource "rediscloud_subscription" "example" {
+resource "rediscloud_subscription" "subscription-resource" {
 
-  name = "example"
+  name = "subscription-name"
   payment_method = "credit-card"
   payment_method_id = data.rediscloud_payment_method.card.id
   memory_storage = "ram"
@@ -53,9 +53,9 @@ resource "rediscloud_subscription" "example" {
 }
 
 // The primary database to provision
-resource "rediscloud_subscription_database" "example" {
-    subscription_id = rediscloud_subscription.example.id
-    name = "example-database"
+resource "rediscloud_subscription_database" "database-resource" {
+    subscription_id = rediscloud_subscription.subscription-resource.id
+    name = "database-name"
     protocol = "redis"
     memory_limit_in_gb = 1
     data_persistence = "none"
@@ -64,7 +64,6 @@ resource "rediscloud_subscription_database" "example" {
     support_oss_cluster_api = false 
     external_endpoint_for_oss_cluster_api = false
     replication = false
-    average_item_size_in_bytes = 0
    
     modules = [
         {
@@ -79,20 +78,20 @@ resource "rediscloud_subscription_database" "example" {
       name = "dataset-size"
       value = 40
     }
-    depends_on = [rediscloud_subscription.example]
+    depends_on = [rediscloud_subscription.subscription-resource]
 
 }
 
 // An example of how a replica database can be provisioned
-resource "rediscloud_subscription_database" "example_replica" {
-    subscription_id = rediscloud_subscription.example.id
-    name = "example-replica"
+resource "rediscloud_subscription_database" "database-resource-replica" {
+    subscription_id = rediscloud_subscription.subscription-resource.id
+    name = "database-name-replica"
     protocol = "redis"
     memory_limit_in_gb = 1
     throughput_measurement_by = "operations-per-second"
     throughput_measurement_value = 10000
-    replica_of = [format("redis://%s", rediscloud_subscription_database.example.public_endpoint)]
-    depends_on = [rediscloud_subscription.example]
+    replica_of = [format("redis://%s", rediscloud_subscription_database.database-resource.public_endpoint)]
+    depends_on = [rediscloud_subscription.subscription-resource]
 
 } 
 ```
@@ -101,9 +100,8 @@ resource "rediscloud_subscription_database" "example_replica" {
 
 The following arguments are supported:
 
-* `subscription_id`: (Required) The ID of the subscription to create the database in.
-* `name` - (Required) A meaningful name to identify the database.
-  the top of the page for more information.
+* `subscription_id` - (Required) The ID of the subscription to create the database in
+* `name` - (Required) A meaningful name to identify the database
 * `throughput_measurement_by` - (Required) Throughput measurement method, (either ‘number-of-shards’ or ‘operations-per-second’)
 * `throughput_measurement_value` - (Required) Throughput value (as applies to selected measurement method)
 * `memory_limit_in_gb` - (Required) Maximum memory usage for this specific database
@@ -117,27 +115,27 @@ The following arguments are supported:
   database will be a replica of. If the URI provided is Redis Labs Cloud instance, only host and port should be provided.
   Cannot be enabled when `support_oss_cluster_api` is enabled.
 * `modules` - (Optional) A list of modules objects, documented below
-* `alert` - (Optional) Set of alerts to enable on the database, documented below
+* `alert` - (Optional) A block defining Redis database alert, documented below, can be specified multiple times
 * `data_persistence` - (Optional) Rate of database data persistence (in persistent storage). Default: ‘none’
-* `data_eviction` - (Optional) The data items eviction policy (either: 'allkeys-lru', 'allkeys-lfu', 'allkeys-random', 'volatile-lru', 'volatile-lfu', 'volatile-random', 'volatile-ttl' or 'noeviction'. Default: 'volatile-lru')
+* `data_eviction` - (Optional) The data items eviction policy (either: 'allkeys-lru', 'allkeys-lfu', 'allkeys-random', 'volatile-lru', 'volatile-lfu', 'volatile-random', 'volatile-ttl' or 'noeviction'). Default: 'volatile-lru'
 * `password` - (Optional) Password to access the database. If omitted, a random 32 character long alphanumeric password will be automatically generated
 * `replication` - (Optional) Databases replication. Default: ‘true’
 * `average_item_size_in_bytes` - (Optional) Relevant only to ram-and-flash clusters. Estimated average size (measured in bytes)
   of the items stored in the database. Default: 1000
-* `source_ips` - (Optional) Set of CIDR addresses to allow access to the database. Defaults to allowing traffic.
+* `source_ips` - (Optional) List of source IP addresses or subnet masks. If specified, Redis clients will be able to connect to this database only from within the specified source IP addresses ranges (example: [‘192.168.10.0/32’, ‘192.168.12.0/24’])
 * `hashing_policy` - (Optional) List of regular expression rules to shard the database by. See
   [the documentation on clustering](https://docs.redislabs.com/latest/rc/concepts/clustering/) for more information on the
   hashing policy. This cannot be set when `support_oss_cluster_api` is set to true.
 * `enable_tls` - (Optional) Use TLS for authentication. Default: ‘false’
 
 The `alert` block supports:
 
-* `name` (Required) Alert name
-* `value` (Required) Alert value
+* `name` (Required) - Alert name
+* `value` (Required) - Alert value
 
-The `modules` attribute supports:
+The `modules` list supports:
 
-* `name` (Required) Name of the Redis Labs database module to enable
+* `name` (Required) - Name of the Redis database module to enable
 
   Example:
 
@@ -170,6 +168,6 @@ The `timeouts` block allows you to specify [timeouts](https://www.terraform.io/l
 `rediscloud_subscription_database` can be imported using the ID of the subscription and the ID of the database in the format {subscription ID}/{database ID}, e.g.
 
 ```
-$ terraform import rediscloud_subscription_database.example_database 123456/12345678
+$ terraform import rediscloud_subscription_database.database-resource 123456/12345678
 ```