fix: module would not warn on redis 9. Extracted out method and unit tested it

Author: burythehammer

provider/pro/resource_rediscloud_pro_database.go

@@ -1048,20 +1048,32 @@ func containsDBModule(modules []map[string]interface{}, moduleName string) bool
 	return false
 }
 
+// shouldWarnRedis8Modules checks if a warning should be issued for modules in Redis 8.0 or higher
+func shouldWarnRedis8Modules(version string, hasModules bool) bool {
+	if !hasModules {
+		return false
+	}
+	// Extract major version (first character before the dot)
+	if len(version) > 0 {
+		majorVersionStr := strings.Split(version, ".")[0]
+		if majorVersion, err := strconv.Atoi(majorVersionStr); err == nil {
+			return majorVersion >= 8
+		}
+	}
+	return false
+}
+
 func validateModulesForRedis8() schema.CustomizeDiffFunc {
 	return func(ctx context.Context, diff *schema.ResourceDiff, meta interface{}) error {
 		redisVersion, versionExists := diff.GetOk("redis_version")
 		modules, modulesExists := diff.GetOkExists("modules")
 
 		if versionExists && modulesExists {
 			version := redisVersion.(string)
-			// Check if version is >= 8.0
-			if strings.HasPrefix(version, "8.") {
-				moduleSet := modules.(*schema.Set)
-				if moduleSet.Len() > 0 {
-					log.Printf("[WARN] Modules are bundled by default in Redis %s. You should remove the modules block as it is deprecated for this version.", version)
-					return nil
-				}
+			moduleSet := modules.(*schema.Set)
+
+			if shouldWarnRedis8Modules(version, moduleSet.Len() > 0) {
+				log.Printf("[WARN] Modules are bundled by default in Redis %s. You should remove the modules block as it is deprecated for this version.", version)
 			}
 		}
 		return nil

provider/pro/resource_rediscloud_pro_database_validation_test.go

@@ -0,0 +1,67 @@
+package pro
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+// TestUnitShouldWarnRedis8Modules_Redis8WithModules tests that warning is triggered for Redis 8.0 with modules
+func TestUnitShouldWarnRedis8Modules_Redis8WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("8.0", true)
+	assert.True(t, result, "should warn for Redis 8.0 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis80WithModules tests that warning is triggered for Redis 8.0.0 with modules
+func TestUnitShouldWarnRedis8Modules_Redis80WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("8.0.0", true)
+	assert.True(t, result, "should warn for Redis 8.0.0 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis81WithModules tests that warning is triggered for Redis 8.1+ with modules
+func TestUnitShouldWarnRedis8Modules_Redis81WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("8.1.0", true)
+	assert.True(t, result, "should warn for Redis 8.1.0 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis89WithModules tests that warning is triggered for Redis 8.9+ with modules
+func TestUnitShouldWarnRedis8Modules_Redis89WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("8.9.9", true)
+	assert.True(t, result, "should warn for Redis 8.9.9 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis7WithModules tests that no warning for Redis 7.x with modules
+func TestUnitShouldWarnRedis8Modules_Redis7WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("7.4", true)
+	assert.False(t, result, "should not warn for Redis 7.4 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis6WithModules tests that no warning for Redis 6.x with modules
+func TestUnitShouldWarnRedis8Modules_Redis6WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("6.2", true)
+	assert.False(t, result, "should not warn for Redis 6.2 with modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis8NoModules tests that no warning for Redis 8.0 without modules
+func TestUnitShouldWarnRedis8Modules_Redis8NoModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("8.0", false)
+	assert.False(t, result, "should not warn for Redis 8.0 without modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis7NoModules tests that no warning for Redis 7.x without modules
+func TestUnitShouldWarnRedis8Modules_Redis7NoModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("7.4", false)
+	assert.False(t, result, "should not warn for Redis 7.4 without modules")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis9WithModules tests that warning is triggered for Redis 9.x with modules (future-proofing)
+func TestUnitShouldWarnRedis8Modules_Redis9WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("9.0", true)
+	assert.True(t, result, "should warn for Redis 9.0 with modules (modules bundled in 8.0+)")
+}
+
+// TestUnitShouldWarnRedis8Modules_Redis10WithModules tests that warning is triggered for Redis 10.x with modules
+func TestUnitShouldWarnRedis8Modules_Redis10WithModules(t *testing.T) {
+	result := shouldWarnRedis8Modules("10.0.0", true)
+	assert.True(t, result, "should warn for Redis 10.0.0 with modules (modules bundled in 8.0+)")
+}