fix: connections object has a mismatch when destroying

Author: burythehammer

.github/workflows/terraform_provider_main.yml

@@ -179,6 +179,17 @@ jobs:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAcc(DataSource|Resource)RedisCloud(TransitGatewayAttachment|PaymentMethod).*"'
 
+  go_unit_test:
+    name: go unit test
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+        with:
+          go-version-file: go.mod
+      - run: go test ./... -short
+
   tfproviderlint:
     name: tfproviderlint
     needs: [go_build]

.github/workflows/terraform_provider_pr.yml

@@ -183,6 +183,17 @@ jobs:
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudPrivateLink_CRUDI"'
 
 
+  go_unit_test:
+    name: go unit test
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
+        with:
+          go-version-file: go.mod
+      - run: go test ./... -short
+
   tfproviderlint:
     name: tfproviderlint
     needs: [go_build]

provider/privatelink/utils.go

@@ -159,7 +159,7 @@ func flattenConnections(connections []*pl.PrivateLinkConnection) []map[string]in
 		tf := map[string]interface{}{
 			"association_id":   redis.StringValue(connection.AssociationId),
 			"connection_id":    redis.StringValue(connection.ConnectionId),
-			"type":             redis.StringValue(connection.Type),
+			"connection_type":  redis.StringValue(connection.Type),
 			"owner_id":         redis.StringValue(connection.OwnerId),
 			"association_date": redis.StringValue(connection.AssociationDate),
 		}

provider/privatelink/utils_test.go

@@ -0,0 +1,97 @@
+package privatelink
+
+import (
+	"testing"
+
+	"github.com/RedisLabs/rediscloud-go-api/redis"
+	pl "github.com/RedisLabs/rediscloud-go-api/service/privatelink"
+	"github.com/stretchr/testify/assert"
+)
+
+func TestFlattenConnections(t *testing.T) {
+	// Test that flattenConnections produces keys that match the schema
+	connections := []*pl.PrivateLinkConnection{
+		{
+			AssociationId:   redis.String("assoc-123"),
+			ConnectionId:    redis.String("conn-456"),
+			Type:            redis.String("vpc-endpoint"),
+			OwnerId:         redis.String("owner-789"),
+			AssociationDate: redis.String("2024-01-01"),
+		},
+	}
+
+	result := flattenConnections(connections)
+
+	assert.Len(t, result, 1)
+
+	conn := result[0]
+	assert.Contains(t, conn, "association_id")
+	assert.Contains(t, conn, "connection_id")
+	assert.Contains(t, conn, "connection_type")
+	assert.Contains(t, conn, "owner_id")
+	assert.Contains(t, conn, "association_date")
+
+	assert.Equal(t, "assoc-123", conn["association_id"])
+	assert.Equal(t, "conn-456", conn["connection_id"])
+	assert.Equal(t, "vpc-endpoint", conn["connection_type"])
+	assert.Equal(t, "owner-789", conn["owner_id"])
+	assert.Equal(t, "2024-01-01", conn["association_date"])
+}
+
+func TestFlattenConnectionsEmpty(t *testing.T) {
+	result := flattenConnections([]*pl.PrivateLinkConnection{})
+	assert.Len(t, result, 0)
+}
+
+func TestFlattenDatabases(t *testing.T) {
+	databases := []*pl.PrivateLinkDatabase{
+		{
+			DatabaseId:           redis.Int(12345),
+			Port:                 redis.Int(16379),
+			ResourceLinkEndpoint: redis.String("endpoint.example.com"),
+		},
+	}
+
+	result := flattenDatabases(databases)
+
+	assert.Len(t, result, 1)
+
+	db := result[0]
+	assert.Contains(t, db, "database_id")
+	assert.Contains(t, db, "port")
+	assert.Contains(t, db, "resource_link_endpoint")
+
+	assert.Equal(t, 12345, db["database_id"])
+	assert.Equal(t, 16379, db["port"])
+	assert.Equal(t, "endpoint.example.com", db["resource_link_endpoint"])
+}
+
+func TestFlattenPrincipals(t *testing.T) {
+	principals := []*pl.PrivateLinkPrincipal{
+		{
+			Principal: redis.String("arn:aws:iam::123456789012:root"),
+			Type:      redis.String("aws_account"),
+			Alias:     redis.String("my-account"),
+		},
+		{
+			Principal: redis.String("arn:aws:iam::987654321098:root"),
+			Type:      redis.String("aws_account"),
+			Alias:     redis.String("another-account"),
+		},
+	}
+
+	result := flattenPrincipals(principals)
+
+	assert.Len(t, result, 2)
+
+	// Verify keys
+	for _, p := range result {
+		assert.Contains(t, p, "principal")
+		assert.Contains(t, p, "principal_type")
+		assert.Contains(t, p, "principal_alias")
+	}
+
+	// Results should be sorted by principal
+	assert.Equal(t, "arn:aws:iam::123456789012:root", result[0]["principal"])
+	assert.Equal(t, "arn:aws:iam::987654321098:root", result[1]["principal"])
+}