Updates to address test lint errors

Author: trentrosenbaum

provider/datasource_rediscloud_acl_rule_test.go

@@ -0,0 +1,42 @@
+package provider
+
+import (
+	"fmt"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"regexp"
+	"testing"
+)
+
+func TestAccDataSourceRedisCloudAclRule_ForDefaultRule(t *testing.T) {
+
+	testAccRequiresEnvVar(t, "EXECUTE_TESTS")
+
+	// This rule already exists
+	const testName = "Read-Write"
+	const testRule = "+@all -@dangerous ~*"
+	getRuleTerraform := fmt.Sprintf(getDefaultDatasourceAclRuleDataSource, testName)
+
+	const AclRuleTest = "data.rediscloud_acl_rule.test"
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: providerFactories,
+		CheckDestroy:      nil, // test doesn't create a resource, so don't need to check anything
+		Steps: []resource.TestStep{
+			{
+				Config: getRuleTerraform,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestMatchResourceAttr(
+						AclRuleTest, "id", regexp.MustCompile("^\\d*$")),
+					resource.TestCheckResourceAttr(AclRuleTest, "name", testName),
+					resource.TestCheckResourceAttr(AclRuleTest, "rule", testRule),
+				),
+			},
+		},
+	})
+}
+
+const getDefaultDatasourceAclRuleDataSource = `
+data "rediscloud_acl_rule" "test" {
+	name = "%s"
+}
+`

provider/rediscloud_acl_rule_test.go renamed to provider/resource_rediscloud_acl_rule_test.go

@@ -12,34 +12,6 @@ import (
 	"testing"
 )
 
-func TestAccDataSourceRedisCloudAclRule_ForDefaultRule(t *testing.T) {
-
-	testAccRequiresEnvVar(t, "EXECUTE_TESTS")
-
-	// This rule already exists
-	const testName = "Read-Write"
-	const testRule = "+@all -@dangerous ~*"
-	getRuleTerraform := fmt.Sprintf(getDefaultAclRuleDataSource, testName)
-
-	const AclRuleTest = "data.rediscloud_acl_rule.test"
-	resource.ParallelTest(t, resource.TestCase{
-		PreCheck:          func() { testAccPreCheck(t) },
-		ProviderFactories: providerFactories,
-		CheckDestroy:      nil, // test doesn't create a resource, so don't need to check anything
-		Steps: []resource.TestStep{
-			{
-				Config: getRuleTerraform,
-				Check: resource.ComposeAggregateTestCheckFunc(
-					resource.TestMatchResourceAttr(
-						AclRuleTest, "id", regexp.MustCompile("^\\d*$")),
-					resource.TestCheckResourceAttr(AclRuleTest, "name", testName),
-					resource.TestCheckResourceAttr(AclRuleTest, "rule", testRule),
-				),
-			},
-		},
-	})
-}
-
 func TestAccResourceRedisCloudAclRule_CRUDI(t *testing.T) {
 
 	testAccRequiresEnvVar(t, "EXECUTE_TESTS")

provider/resource_rediscloud_pro_tls_test.go

@@ -229,7 +229,7 @@ func TestAccResourceRedisCloudSubscriptionTls_createWithDatabaseWithEnabledTlsAn
 }
 
 // enable_tls=false, client_ssl_certificate=<invalid>
-func TestAccResourceRedisCloudSubscription_createWithDatabaseAndDisabledTlsAndInvalidCert(t *testing.T) {
+func TestAccResourceRedisCloudSubscriptionTls_createWithDatabaseAndDisabledTlsAndInvalidCert(t *testing.T) {
 
 	testAccRequiresEnvVar(t, "EXECUTE_TEST_SUBSCRIPTION")