Skip to content

Commit 7df01ef

Browse files
burythehammerburythehammer
authored
Merge pull request #611 from RedisLabs/fix/adjust-service-attachments
Updates the service_attachments to reduce from 40 to 1
2 parents 8386f3a + c8637dd commit 7df01ef

14 files changed

+22
-22
lines changed

‎docs/data-sources/rediscloud_private_service_connect_endpoints.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ The `endpoints` object has these attributes:
3939
* `gcp_vpc_subnet_name` - The GCP Subnet name
4040
* `endpoint_connection_name` - The endpoint connection name
4141
* `status` - The endpoint status
42-
* `service_attachments` - The 40 service attachments that are created for the Private Service Connect endpoint, documented below
42+
* `service_attachments` - The service attachments that are created for the Private Service Connect endpoint, documented below
4343

4444
The `service_attachments` object has these attributes:
4545

‎docs/guides/migration-guide-v1.0.0.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ resource "rediscloud_subscription" "example" {
7070
7171
alert {
7272
name = "dataset-size"
73-
value = 40
73+
value = 1
7474
}
7575
}
7676
}
@@ -132,7 +132,7 @@ To use the latest schema, you need to modify the `rediscloud_subscription` resou
132132
133133
alert {
134134
name = "dataset-size"
135-
value = 40
135+
value = 1
136136
}
137137
}
138138
```

‎docs/resources/rediscloud_active_active_private_service_connect_endpoint.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ resource "rediscloud_active_active_subscription_regions" "regions" {
7979
}
8080
8181
locals {
82-
service_attachment_count = 40 # Each rediscloud_active_active_private_service_connect_endpoint will have exactly 40 service attachments
82+
service_attachment_count = 1 # Each rediscloud_active_active_private_service_connect_endpoint will have exactly 1 service attachment
8383
region_id = one([for r in rediscloud_active_active_subscription_regions.regions.region : r.region_id if r.region == var.gcp_region])
8484
}
8585

‎docs/resources/rediscloud_active_active_subscription_database.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ resource "rediscloud_active_active_subscription_database" "database-resource" {
5050
global_source_ips = ["192.168.0.0/16"]
5151
global_alert {
5252
name = "dataset-size"
53-
value = 40
53+
value = 1
5454
}
5555
5656
global_modules = ["RedisJSON"]
@@ -161,4 +161,4 @@ To update an existing configuration for a database which uses the `memory_limit_
161161
$ terraform state rm rediscloud_active_active_subscription_database.database-resource
162162
(Update the configuration to use `dataset_size_in_gb` instead of `memory_limit_in_gb`)
163163
$ terraform import rediscloud_active_active_subscription_database.database-resource 123456/12345678
164-
```
164+
```

‎docs/resources/rediscloud_private_service_connect_endpoint.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ resource "rediscloud_subscription" "subscription" {
4343
}
4444
4545
locals {
46-
service_attachment_count = 40 # Each rediscloud_private_service_connect_endpoint will have exactly 40 service attachments
46+
service_attachment_count = 1 # Each rediscloud_private_service_connect_endpoint will have exactly 1 service attachment
4747
}
4848
4949
resource "rediscloud_private_service_connect" "service" {
@@ -195,7 +195,7 @@ module "private_service_connect" {
195195
## Attribute Reference
196196

197197
* `private_service_connect_endpoint_id` - The ID of the Private Service Connect Endpoint
198-
* `service_attachments` - The 40 service attachments that are created for the Private Service Connect endpoint, documented below
198+
* `service_attachments` - The service attachment that is created for the Private Service Connect endpoint, documented below
199199

200200
The `service_attachments` object has these attributes:
201201

‎docs/resources/rediscloud_subscription_database.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ resource "rediscloud_subscription_database" "database-resource" {
6565
6666
alert {
6767
name = "dataset-size"
68-
value = 40
68+
value = 1
6969
}
7070
7171
tags = {
@@ -171,4 +171,4 @@ To update an existing configuration for a database which uses the `memory_limit_
171171
$ terraform state rm rediscloud_subscription_database.database-resource
172172
(Update the configuration to use `dataset_size_in_gb` instead of `memory_limit_in_gb`)
173173
$ terraform import rediscloud_subscription_database.database-resource 123456/12345678
174-
```
174+
```

‎provider/datasource_rediscloud_pro_subscription_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
167167
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
168168
global_alert {
169169
name = "dataset-size"
170-
value = 40
170+
value = 1
171171
}
172172
override_region {
173173
name = "us-east-1"

‎provider/rediscloud_active_active_database_test.go‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestAccResourceRedisCloudActiveActiveDatabase_CRUDI(t *testing.T) {
4848
resource.TestCheckResourceAttr(resourceName, "data_eviction", "volatile-lru"),
4949
resource.TestCheckResourceAttr(resourceName, "global_alert.#", "1"),
5050
resource.TestCheckResourceAttr(resourceName, "global_alert.0.name", "dataset-size"),
51-
resource.TestCheckResourceAttr(resourceName, "global_alert.0.value", "40"),
51+
resource.TestCheckResourceAttr(resourceName, "global_alert.0.value", "1"),
5252
resource.TestCheckResourceAttr(resourceName, "global_modules.#", "1"),
5353
resource.TestCheckResourceAttr(resourceName, "global_modules.0", "RedisJSON"),
5454
resource.TestCheckResourceAttr(resourceName, "global_source_ips.#", "2"),
@@ -294,7 +294,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
294294
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
295295
global_alert {
296296
name = "dataset-size"
297-
value = 40
297+
value = 1
298298
}
299299
global_modules = ["RedisJSON"]
300300
override_region {
@@ -433,7 +433,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
433433
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
434434
global_alert {
435435
name = "dataset-size"
436-
value = 40
436+
value = 1
437437
}
438438
override_region {
439439
name = "us-east-1"
@@ -466,7 +466,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
466466
global_source_ips = ["192.168.0.0/16", "192.170.0.0/16"]
467467
global_alert {
468468
name = "dataset-size"
469-
value = 40
469+
value = 1
470470
}
471471
override_region {
472472
name = "us-east-1"

‎provider/rediscloud_active_active_private_service_connect_endpoint_accepter_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ resource "google_compute_subnetwork" "subnet" {
161161
}
162162
163163
locals {
164-
service_attachment_count = 40
164+
service_attachment_count = 1
165165
}
166166
167167
resource "google_compute_address" "default" {

‎provider/rediscloud_active_active_private_service_connect_endpoint_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestAccResourceRedisCloudActiveActivePrivateServiceConnectEndpoint_CRUDI(t
4848
}
4949
return nil
5050
}),
51-
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "40"),
51+
resource.TestCheckResourceAttr(datasourceName, "endpoints.0.service_attachments.#", "1"),
5252
),
5353
},
5454
{

0 commit comments

Comments
 (0)