Updates to check that the QPF is within 2x to 16x range

Author: trentrosenbaum

provider/resource_rediscloud_pro_subscription.go

@@ -294,6 +294,18 @@ func resourceRedisCloudProSubscription() *schema.Resource {
 							Type:        schema.TypeString,
 							Optional:    true,
 							Computed:    true,
+							ValidateFunc: func(val interface{}, key string) (warns []string, errs []error) {
+								v := val.(string)
+								matched, err := regexp.MatchString(`^(2|4|6|8|10|12|14|16)x$`, v)
+								if err != nil {
+									errs = append(errs, fmt.Errorf("regex match failed: %s", err))
+									return
+								}
+								if !matched {
+									errs = append(errs, fmt.Errorf("%q must be an even value between 2x and 16x (inclusive), got: %s", key, v))
+								}
+								return
+							},
 						},
 						"throughput_measurement_by": {
 							Description:      "Throughput measurement method, (either ‘number-of-shards’ or ‘operations-per-second’)",

provider/resource_rediscloud_pro_subscription_qpf_test.go

@@ -127,3 +127,23 @@ func TestAccResourceRedisCloudProSubscription_missingRediSearchModule(t *testing
 
 	testSubErrorCase(t, config, regexp.MustCompile("query_performance_factor\" requires the \"modules\" list to contain \"RediSearch"))
 }
+
+func TestAccRedisCloudDatabase_invalidQueryPerformanceFactors(t *testing.T) {
+	name := acctest.RandomWithPrefix("tf-test")
+	password := acctest.RandString(20)
+	testCloudAccountName := os.Getenv("AWS_TEST_CLOUD_ACCOUNT_NAME")
+
+	config := formatDatabaseConfig(name, testCloudAccountName, password, "5x", `modules = [{ name = "RediSearch" }]`)
+
+	testSubErrorCase(t, config, regexp.MustCompile(`"creation_plan\.0\.query_performance_factor" must be an even value between 2x and 16x \(inclusive\), got: 5x`))
+}
+
+func TestAccRedisCloudDatabase_invalidQueryPerformanceFactors_outOfRange(t *testing.T) {
+	name := acctest.RandomWithPrefix("tf-test")
+	password := acctest.RandString(20)
+	testCloudAccountName := os.Getenv("AWS_TEST_CLOUD_ACCOUNT_NAME")
+
+	config := formatDatabaseConfig(name, testCloudAccountName, password, "30x", `modules = [{ name = "RediSearch" }]`)
+
+	testSubErrorCase(t, config, regexp.MustCompile(`"creation_plan\.0\.query_performance_factor" must be an even value between 2x and 16x \(inclusive\), got: 30x`))
+}