test: moving aa sub tests over to the specific test for region resource

Author: burythehammer

.github/workflows/terraform_provider_pr.yml

@@ -140,7 +140,7 @@ jobs:
 
   go_test_smoke_misc:
     name: go test smoke misc
-    needs: [go_build]
+    needs: [ go_build ]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -149,6 +149,18 @@ jobs:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloud(PrivateServiceConnect_CRUDI|AclRule_CRUDI)"'
 
+  # TODO: remove, temporary: tests the subscription regions
+  go_test_smoke_aa_sub_regions:
+    name: go test smoke aa sub regions
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+      - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
+        with:
+          go-version-file: go.mod
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveSubscriptionRegions_CRUDI"'
+
   tfproviderlint:
     name: tfproviderlint
     needs: [go_build]

provider/rediscloud_active_active_database_test.go

@@ -22,7 +22,7 @@ func TestAccResourceRedisCloudActiveActiveDatabase_CRUDI(t *testing.T) {
 	password := acctest.RandString(20)
 	const databaseResourceName = "rediscloud_active_active_subscription_database.example"
 	const datasourceName = "data.rediscloud_active_active_subscription_database.example"
-	const datasourceRegionName = "data.rediscloud_active_active_subscription_regions.foo"
+	const datasourceRegionName = "data.rediscloud_active_active_subscription_regions.example"
 	const subscriptionResourceName = "rediscloud_active_active_subscription.example"
 
 	var subId int
@@ -124,20 +124,9 @@ func TestAccResourceRedisCloudActiveActiveDatabase_CRUDI(t *testing.T) {
 					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.0.vpc_id"),
 					resource.TestCheckResourceAttr(datasourceRegionName, "regions.0.region", "us-east-1"),
 					resource.TestCheckResourceAttr(datasourceRegionName, "regions.0.networking_deployment_cidr", "192.168.0.0/24"),
-
-					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.0.databases.0.database_id"),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.0.databases.0.database_name", databaseName),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.0.databases.0.read_operations_per_second", "1000"),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.0.databases.0.write_operations_per_second", "1000"),
-
 					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.1.vpc_id"),
 					resource.TestCheckResourceAttr(datasourceRegionName, "regions.1.region", "us-east-2"),
 					resource.TestCheckResourceAttr(datasourceRegionName, "regions.1.networking_deployment_cidr", "10.0.1.0/24"),
-
-					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.1.databases.0.database_id"),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.1.databases.0.database_name", databaseName),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.1.databases.0.read_operations_per_second", "1000"),
-					resource.TestCheckResourceAttr(datasourceRegionName, "regions.1.databases.0.write_operations_per_second", "1000"),
 				),
 			},
 			// Test database is updated successfully, including updates to both global and local alerts and clearing modules
@@ -342,7 +331,7 @@ data "rediscloud_active_active_subscription_database" "example" {
 	name = rediscloud_active_active_subscription_database.example.name
 }
 
-data "rediscloud_active_active_subscription_regions" "foo" {
+data "rediscloud_active_active_subscription_regions" "example" {
 	subscription_name = rediscloud_active_active_subscription.example.name
 }
 `

provider/rediscloud_active_active_subscription_test.go

@@ -29,7 +29,7 @@ func TestAccResourceRedisCloudActiveActiveSubscription_CRUDI(t *testing.T) {
 	name := acctest.RandomWithPrefix(testResourcePrefix)
 	const resourceName = "rediscloud_active_active_subscription.example"
 	const datasourceSubscriptionName = "data.rediscloud_active_active_subscription.example"
-	const datasourceRegionName = "data.rediscloud_active_active_subscription_regions.foo"
+	const datasourceRegionName = "data.rediscloud_active_active_subscription_regions.example"
 
 	var subId int
 
@@ -426,7 +426,7 @@ data "rediscloud_active_active_subscription" "example" {
 	name = rediscloud_active_active_subscription.example.name
 }
 
-data "rediscloud_active_active_subscription_regions" "foo" {
+data "rediscloud_active_active_subscription_regions" "example" {
 	subscription_name = rediscloud_active_active_subscription.example.name
 }
 `

provider/resource_rediscloud_active_active_subscription_regions_test.go

@@ -20,6 +20,7 @@ func TestAccResourceRedisCloudActiveActiveSubscriptionRegions_CRUDI(t *testing.T
 	dbName := acctest.RandomWithPrefix(testResourcePrefix) + "-regions" + "-db"
 	dbPass := acctest.RandString(20)
 	const resourceName = "rediscloud_active_active_subscription_regions.example"
+	const datasourceRegionName = "data.rediscloud_active_active_subscription_regions.example"
 
 	var subId int
 
@@ -39,6 +40,16 @@ func TestAccResourceRedisCloudActiveActiveSubscriptionRegions_CRUDI(t *testing.T
 					resource.TestCheckResourceAttr(resourceName, "region.2.database.0.local_write_operations_per_second", "1500"),
 					resource.TestCheckResourceAttr(resourceName, "region.2.database.0.local_read_operations_per_second", "1500"),
 
+					// Test the db regions datasource
+					resource.TestCheckResourceAttr(datasourceRegionName, "subscription_name", subName),
+					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.2.vpc_id"),
+					resource.TestCheckResourceAttr(datasourceRegionName, "regions.2.region", "us-west-2"),
+					resource.TestCheckResourceAttr(datasourceRegionName, "regions.2.networking_deployment_cidr", "10.2.0.0/24"),
+					resource.TestCheckResourceAttrSet(datasourceRegionName, "regions.2.databases.0.database_id"),
+					resource.TestCheckResourceAttr(datasourceRegionName, "regions.2.databases.0.database_name", dbName),
+					resource.TestCheckResourceAttr(datasourceRegionName, "regions.2.databases.0.read_operations_per_second", "1500"),
+					resource.TestCheckResourceAttr(datasourceRegionName, "regions.2.databases.0.write_operations_per_second", "1500"),
+
 					func(s *terraform.State) error {
 						r := s.RootModule().Resources[resourceName]
 
@@ -152,6 +163,10 @@ resource "rediscloud_active_active_subscription_database" "example" {
 	}
 } 
 
+data "rediscloud_active_active_subscription_regions" "example" {
+	subscription_name = rediscloud_active_active_subscription.example.name
+}
+
 `
 
 // TF config for provisioning a new region.