fix: suppresses diffs for redis 8

Author: burythehammer

provider/pro/resource_rediscloud_pro_database.go

@@ -251,8 +251,9 @@ func ResourceRedisCloudProDatabase() *schema.Resource {
 				ConfigMode: schema.SchemaConfigModeAttr,
 				Optional:   true,
 				// The API doesn't allow updating/delete modules. Unless we recreate the database.
-				ForceNew: true,
-				MinItems: 1,
+				ForceNew:         true,
+				MinItems:         1,
+				DiffSuppressFunc: modulesDiffSuppressFunc,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"name": {
@@ -1068,6 +1069,30 @@ func shouldWarnRedis8Modules(version string, hasModules bool) bool {
 	return false
 }
 
+// shouldSuppressModuleDiffsForRedis8 checks if module diffs should be suppressed for Redis 8.0 or higher
+// In Redis 8.0+, modules are bundled by default, so we should ignore changes to explicitly configured modules
+func shouldSuppressModuleDiffsForRedis8(version string) bool {
+	if len(version) == 0 {
+		return false
+	}
+	majorVersionStr := strings.Split(version, ".")[0]
+	if majorVersion, err := strconv.Atoi(majorVersionStr); err == nil {
+		return majorVersion >= 8
+	}
+	return false
+}
+
+// modulesDiffSuppressFunc returns a DiffSuppressFunc that suppresses module diffs for Redis 8.0+
+// This prevents Terraform from showing module changes as "forces replacement" when upgrading to Redis 8.0+
+func modulesDiffSuppressFunc(k, oldValue, newValue string, d *schema.ResourceData) bool {
+	redisVersion, ok := d.GetOk("redis_version")
+	if !ok {
+		return false
+	}
+	version := redisVersion.(string)
+	return shouldSuppressModuleDiffsForRedis8(version)
+}
+
 func validateModulesForRedis8() schema.CustomizeDiffFunc {
 	return func(ctx context.Context, diff *schema.ResourceDiff, meta interface{}) error {
 		redisVersion, versionExists := diff.GetOk("redis_version")

provider/pro/resource_rediscloud_pro_database_validation_test.go

@@ -65,3 +65,33 @@ func TestUnitShouldWarnRedis8Modules_Redis10WithModules(t *testing.T) {
 	result := shouldWarnRedis8Modules("10.0.0", true)
 	assert.True(t, result, "should warn for Redis 10.0.0 with modules (modules bundled in 8.0+)")
 }
+
+// TestUnitShouldSuppressModuleDiffsForRedis8_Redis8 tests that module diffs are suppressed for Redis 8.0
+func TestUnitShouldSuppressModuleDiffsForRedis8_Redis8(t *testing.T) {
+	result := shouldSuppressModuleDiffsForRedis8("8.0")
+	assert.True(t, result, "should suppress module diffs for Redis 8.0")
+}
+
+// TestUnitShouldSuppressModuleDiffsForRedis8_Redis82 tests that module diffs are suppressed for Redis 8.2
+func TestUnitShouldSuppressModuleDiffsForRedis8_Redis82(t *testing.T) {
+	result := shouldSuppressModuleDiffsForRedis8("8.2")
+	assert.True(t, result, "should suppress module diffs for Redis 8.2")
+}
+
+// TestUnitShouldSuppressModuleDiffsForRedis8_Redis9 tests that module diffs are suppressed for Redis 9.0
+func TestUnitShouldSuppressModuleDiffsForRedis8_Redis9(t *testing.T) {
+	result := shouldSuppressModuleDiffsForRedis8("9.0")
+	assert.True(t, result, "should suppress module diffs for Redis 9.0")
+}
+
+// TestUnitShouldSuppressModuleDiffsForRedis8_Redis7 tests that module diffs are NOT suppressed for Redis 7.x
+func TestUnitShouldSuppressModuleDiffsForRedis8_Redis7(t *testing.T) {
+	result := shouldSuppressModuleDiffsForRedis8("7.4")
+	assert.False(t, result, "should not suppress module diffs for Redis 7.4")
+}
+
+// TestUnitShouldSuppressModuleDiffsForRedis8_Redis6 tests that module diffs are NOT suppressed for Redis 6.x
+func TestUnitShouldSuppressModuleDiffsForRedis8_Redis6(t *testing.T) {
+	result := shouldSuppressModuleDiffsForRedis8("6.2")
+	assert.False(t, result, "should not suppress module diffs for Redis 6.2")
+}