fix: minor upgrades disabled as not ready in production yet

Author: burythehammer

.github/workflows/terraform_provider_pr.yml

@@ -56,6 +56,28 @@ jobs:
         name: go build
         run: go build -o terraform-plugin-dir/registry.terraform.io/RedisLabs/rediscloud/99.99.99/$(go env GOOS)_$(go env GOARCH)/terraform-provider-rediscloud .
 
+  go_unit_test:
+    name: go unit test
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
+
+  tfproviderlint:
+    name: tfproviderlint
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: make tfproviderlint
+
   terraform_providers_schema:
     name: terraform providers schema
     needs: [go_build]
@@ -102,20 +124,21 @@ jobs:
           mkdir terraform-providers-schema
           terraform providers schema -json > terraform-providers-schema/schema.json
 
-  go_test_smoke_aa_db:
-    name: go test smoke aa db
-    needs: [go_build]
+  # All acceptance tests run in parallel after quick tests
+  go_test_smoke_aa_tgw_attachment:
+    name: go test smoke aa tgw attachment
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveDatabase_CRUDI"'
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"'
 
   go_test_smoke_aa_enable_default_user:
     name: go test smoke aa enable default user
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -124,20 +147,20 @@ jobs:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveDatabase_enableDefaultUser"'
 
-  go_test_smoke_aa_tgw_attachment:
-    name: go test smoke aa tgw attachment
-    needs: [go_build]
+  go_test_smoke_aa_db:
+    name: go test smoke aa db
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"'
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveDatabase_CRUDI"'
 
   go_test_smoke_essentials_sub:
     name: go test smoke essentials sub
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -161,7 +184,7 @@ jobs:
 
   go_test_smoke_pro_db:
     name: go test smoke pro db
-    needs: [go_build]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -173,7 +196,7 @@ jobs:
 
   go_test_smoke_misc:
     name: go test smoke misc
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
@@ -184,7 +207,7 @@ jobs:
 
   go_test_pro_db_upgrade:
     name: go test smoke pro db upgrade
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -195,7 +218,7 @@ jobs:
 
   go_test_privatelink:
     name: go test smoke privatelink
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -207,7 +230,7 @@ jobs:
 
   go_test_block_public_endpoints:
     name: go test smoke public endpoints
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
@@ -218,33 +241,11 @@ jobs:
 
   go_test_smoke_qpf:
     name: go test smoke query performance factor
-    needs: [ go_build ]
+    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudProDatabase_qpf"'
-
-  go_unit_test:
-    name: go unit test
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
-
-  tfproviderlint:
-    name: tfproviderlint
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: make tfproviderlint

provider/pro/resource_rediscloud_pro_database.go

@@ -298,10 +298,8 @@ func ResourceRedisCloudProDatabase() *schema.Resource {
 				Default:     true,
 			},
 			"auto_minor_version_upgrade": {
-				Description: "When 'true', enables auto minor version upgrades for this database. Default: 'true'",
-				Type:        schema.TypeBool,
-				Optional:    true,
-				Default:     true,
+				Type:     schema.TypeBool,
+				Optional: true,
 			},
 			"port": {
 				Description:      "TCP port on which the database is available",
@@ -759,13 +757,12 @@ func resourceRedisCloudProDatabaseUpdate(ctx context.Context, d *schema.Resource
 			Value: utils.GetInt(d, "throughput_measurement_value"),
 		},
 
-		DataPersistence:         utils.GetString(d, "data_persistence"),
-		DataEvictionPolicy:      utils.GetString(d, "data_eviction"),
-		SourceIP:                utils.SetToStringSlice(d.Get("source_ips").(*schema.Set)),
-		Alerts:                  &alerts,
-		RemoteBackup:            BuildBackupPlan(d.Get("remote_backup").([]interface{}), d.Get("periodic_backup_path")),
-		EnableDefaultUser:       utils.GetBool(d, "enable_default_user"),
-		AutoMinorVersionUpgrade: utils.GetBool(d, "auto_minor_version_upgrade"),
+		DataPersistence:    utils.GetString(d, "data_persistence"),
+		DataEvictionPolicy: utils.GetString(d, "data_eviction"),
+		SourceIP:           utils.SetToStringSlice(d.Get("source_ips").(*schema.Set)),
+		Alerts:             &alerts,
+		RemoteBackup:       BuildBackupPlan(d.Get("remote_backup").([]interface{}), d.Get("periodic_backup_path")),
+		EnableDefaultUser:  utils.GetBool(d, "enable_default_user"),
 	}
 
 	// One of the following fields must be set, validation is handled in the schema (ExactlyOneOf)
@@ -810,6 +807,11 @@ func resourceRedisCloudProDatabaseUpdate(ctx context.Context, d *schema.Resource
 		update.Password = redis.String(d.Get("password").(string))
 	}
 
+	// Only send auto_minor_version_upgrade if explicitly set
+	if v, ok := d.GetOk("auto_minor_version_upgrade"); ok {
+		update.AutoMinorVersionUpgrade = redis.Bool(v.(bool))
+	}
+
 	update.ReplicaOf = utils.SetToStringSlice(d.Get("replica_of").(*schema.Set))
 	if update.ReplicaOf == nil {
 		update.ReplicaOf = make([]*string, 0)

provider/rediscloud_active_active_database_test.go

@@ -516,6 +516,7 @@ resource "rediscloud_active_active_subscription_database" "example" {
 `
 
 func TestAccResourceRedisCloudActiveActiveDatabase_autoMinorVersionUpgrade(t *testing.T) {
+	t.Skip("auto_minor_version_upgrade feature disabled - planned for release with Redis 8.4 in January")
 
 	utils.AccRequiresEnvVar(t, "EXECUTE_TESTS")
 

provider/resource_rediscloud_active_active_database.go

@@ -208,10 +208,8 @@ func resourceRedisCloudActiveActiveDatabase() *schema.Resource {
 				Default:     true,
 			},
 			"auto_minor_version_upgrade": {
-				Description: "When 'true', enables auto minor version upgrades for this database. Default: 'true'",
-				Type:        schema.TypeBool,
-				Optional:    true,
-				Default:     true,
+				Type:     schema.TypeBool,
+				Optional: true,
 			},
 			"override_region": {
 				Description: "Region-specific configuration parameters to override the global configuration",

provider/resource_rediscloud_pro_database_test.go

@@ -276,6 +276,7 @@ func TestAccResourceRedisCloudProDatabase_respversion(t *testing.T) {
 }
 
 func TestAccResourceRedisCloudProDatabase_autoMinorVersionUpgrade(t *testing.T) {
+	t.Skip("auto_minor_version_upgrade feature disabled - planned for release with Redis 8.4 in January")
 
 	utils.AccRequiresEnvVar(t, "EXECUTE_TESTS")