test: active active test for public endpoints

Author: burythehammer

provider/rediscloud_active_active_database_block_public_endpoints_test.go

@@ -0,0 +1,46 @@
+package provider
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/RedisLabs/terraform-provider-rediscloud/provider/utils"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccActiveActiveSubscriptionDatabaseBlockPublicEndpoints(t *testing.T) {
+
+	utils.AccRequiresEnvVar(t, "EXECUTE_TESTS")
+
+	const databaseResource = "rediscloud_active_active_subscription_database.example"
+	subscriptionName := acctest.RandomWithPrefix(testResourcePrefix)
+
+	content := utils.GetTestConfig(t, "./activeactive/testdata/public_endpoint_disabled.tf")
+	config := fmt.Sprintf(content, subscriptionName)
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t); testAccAwsPreExistingCloudAccountPreCheck(t) },
+		ProviderFactories: providerFactories,
+		CheckDestroy:      testAccCheckActiveActiveSubscriptionDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: config,
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr(databaseResource, "name", subscriptionName),
+					resource.TestCheckResourceAttr(databaseResource, "dataset_size_in_gb", "1"),
+					resource.TestCheckResourceAttr(databaseResource, "global_data_persistence", "aof-every-1-second"),
+					resource.TestCheckResourceAttr(databaseResource, "global_modules.#", "1"),
+					resource.TestCheckResourceAttr(databaseResource, "global_modules.0", "RedisJSON"),
+					resource.TestCheckResourceAttr(databaseResource, "global_alert.#", "1"),
+					resource.TestCheckResourceAttr(databaseResource, "global_alert.0.name", "dataset-size"),
+					resource.TestCheckResourceAttr(databaseResource, "global_alert.0.value", "40"),
+					resource.TestCheckResourceAttr(databaseResource, "global_source_ips.#", "1"),
+					resource.TestCheckResourceAttr(databaseResource, "global_source_ips.0", "192.168.0.0/16"),
+					resource.TestCheckResourceAttrSet(databaseResource, "override_region.0.source_ips"),
+				),
+			},
+		},
+	})
+
+}

provider/datasource_rediscloud_pro_database_block_public_endpoints_test.go renamed to provider/rediscloud_pro_database_block_public_endpoints_test.go

@@ -9,7 +9,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
-func TestAccDataSourceRedisCloudProDatabaseBlockPublicEndpoints(t *testing.T) {
+func TestAccRedisCloudProDatabaseBlockPublicEndpoints(t *testing.T) {
 
 	utils.AccRequiresEnvVar(t, "EXECUTE_TESTS")
 

provider/resource_rediscloud_active_active_database.go

@@ -560,10 +560,11 @@ func resourceRedisCloudActiveActiveDatabaseRead(ctx context.Context, d *schema.R
 			"name": region,
 		}
 
-		// Handle source_ips based on subscription's public_endpoint_access setting
+		// Handle source_ips based on subscription's public_endpoint_access settings
 		// When public_endpoint_access is false and source_ips is empty, API returns private IP ranges
 		// When public_endpoint_access is true and source_ips is empty, API returns ["0.0.0.0/0"]
 		// When source_ips is explicitly set by user, API returns the user's input
+		// This is to prevent drift in terraform state as API response will differ from what terraform sees
 		var sourceIPs []string
 		privateIPRanges := []string{"10.0.0.0/8", "172.16.0.0/12", "192.168.0.0/16", "100.64.0.0/10"}