Skip to content

Commit f5732d1

Browse files
committed
fix: adding logs for invalid database modules in redis 8
1 parent 9825885 commit f5732d1

File tree

1 file changed

+17
-2
lines changed

1 file changed

+17
-2
lines changed

provider/pro/resource_rediscloud_pro_database.go

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1119,8 +1119,23 @@ func modulesDiffSuppressFunc(k, oldValue, newValue string, d *schema.ResourceDat
11191119

11201120
func validateModulesForRedis8() schema.CustomizeDiffFunc {
11211121
return func(ctx context.Context, diff *schema.ResourceDiff, meta interface{}) error {
1122-
// Module warnings are now shown to users in Create/Update functions
1123-
// This function is kept for potential future validation logic
1122+
// Check if modules are configured for Redis 8.0+
1123+
redisVersionRaw, ok := diff.GetOk("redis_version")
1124+
if !ok {
1125+
return nil
1126+
}
1127+
redisVersion := redisVersionRaw.(string)
1128+
1129+
modulesRaw, ok := diff.GetOk("modules")
1130+
if !ok {
1131+
return nil
1132+
}
1133+
modules := modulesRaw.(*schema.Set)
1134+
1135+
if shouldWarnRedis8Modules(redisVersion, modules.Len() > 0) {
1136+
log.Printf("[WARN] Modules are bundled by default in Redis %s and later versions. The 'modules' block is deprecated for Redis 8.0+ as modules (RediSearch, RedisJSON, RedisBloom, RedisTimeSeries) are bundled by default. You should remove the 'modules' block from your configuration.", redisVersion)
1137+
}
1138+
11241139
return nil
11251140
}
11261141
}

0 commit comments

Comments
 (0)