Merge pull request #704 from RedisLabs/fix/revert-regressions-in-global-overrides

Revert regressions in global overrides

Author: burythehammer

.github/workflows/terraform_provider_pr.yml

@@ -56,28 +56,6 @@ jobs:
         name: go build
         run: go build -o terraform-plugin-dir/registry.terraform.io/RedisLabs/rediscloud/99.99.99/$(go env GOOS)_$(go env GOARCH)/terraform-provider-rediscloud .
 
-  go_unit_test:
-    name: go unit test
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
-
-  tfproviderlint:
-    name: tfproviderlint
-    needs: [go_build]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
-        with:
-          go-version-file: go.mod
-      - run: make tfproviderlint
-
   terraform_providers_schema:
     name: terraform providers schema
     needs: [go_build]
@@ -124,29 +102,28 @@ jobs:
           mkdir terraform-providers-schema
           terraform providers schema -json > terraform-providers-schema/schema.json
 
-  # All acceptance tests run in parallel after quick tests
-  go_test_smoke_aa_tgw_attachment:
-    if: false  # Temporarily disabled - TGW tests not ready yet
-    name: go test smoke aa tgw attachment
-    needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
+  go_unit_test:
+    name: go unit test
+    needs: [go_build]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"'
+      - run: go test ./... -run="^TestUnit"  # Runs tests starting with TestUnit
 
-  go_test_smoke_aa_enable_default_user:
-    name: go test smoke aa enable default user
+  go_test_smoke_aa_tgw_attachment:
+    if: false  # Temporarily disabled - TGW tests not ready yet
+    name: go test smoke aa tgw attachment
     needs: [go_unit_test, tfproviderlint, terraform_providers_schema]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
         with:
           go-version-file: go.mod
-      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveDatabase_enableDefaultUser"'
+      - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudActiveActiveTransitGatewayAttachment_CRUDI"'
 
   go_test_smoke_aa_db:
     name: go test smoke aa db
@@ -250,3 +227,14 @@ jobs:
         with:
           go-version-file: go.mod
       - run: EXECUTE_TESTS=true make testacc TESTARGS='-run="TestAccResourceRedisCloudProDatabase_qpf"'
+
+  tfproviderlint:
+    name: tfproviderlint
+    needs: [go_build]
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+      - uses: actions/setup-go@44694675825211faa026b3c33043df3e48a5fa00 # v6.0.0
+        with:
+          go-version-file: go.mod
+      - run: make tfproviderlint

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 See updating [Changelog example here](https://keepachangelog.com/en/1.0.0/)
 
 
+# 2.7.4 (7th November 2025)
+
+## Changed
+- Reverted global/regional override rework from v2.7.3 due to regressions. Active-Active database global configuration behavior has been restored to v2.7.2 state. Transit Gateway improvements from v2.7.3 have been preserved.
+- `rediscloud_active_active_subscription_database`: Both `global_enable_default_user` and the region-level `enable_default_user` (in `override_region` blocks) now default to `true`. To disable the default user in a specific region, you must explicitly set `enable_default_user = false` in that region's `override_region` block.
+
 # 2.7.3 (6th November 2025)
 
 ## Changed

docs/data-sources/rediscloud_active_active_subscription_database.md

@@ -50,6 +50,7 @@ data "rediscloud_active_active_subscription_database" "example" {
 * `enable_tls` - Enable TLS for database.
 * `tls_certificate` - TLS certificate used for authentication.
 * `global_source_ips` - Set of CIDR addresses to allow access to the database.
+* `global_enable_default_user` - Whether the 'default' user is enabled for connecting to the database across all regions.
 * `data_eviction` - The data items eviction policy.
 * `global_modules` - A list of modules to be enabled on all deployments of this database.
 * `public_endpoint` - Public endpoint to access the database.

docs/resources/rediscloud_active_active_subscription_database.md

@@ -103,7 +103,7 @@ The following arguments are supported:
 * `global_alert` - (Optional) A block defining Redis database alert of regions that don't override global settings, documented below, can be specified multiple times. (either: 'dataset-size', 'datasets-size', 'throughput-higher-than', 'throughput-lower-than', 'latency', 'syncsource-error', 'syncsource-lag' or 'connections-limit')
 * `global_modules` - (Optional) A list of modules to be enabled on all deployments of this database. Supported modules: `RedisJSON`, `RediSearch`. Ignored after database creation.
 * `global_source_ips` - (Optional) List of source IP addresses or subnet masks that are allowed to connect to the database across all regions that don't override this setting (example: ['192.168.10.0/32', '192.168.12.0/24']). When not specified, the default behavior depends on the subscription's `public_endpoint_access` setting: if `false`, defaults to RFC1918 private IP ranges (10.0.0.0/8, 172.16.0.0/12, 192.168.0.0/16, 100.64.0.0/10); if `true`, defaults to 0.0.0.0/0 (unrestricted public access)
-* `global_enable_default_user` - (Optional) When 'true', enables connecting to the database with the 'default' user across all regions. Default: 'true'
+* `global_enable_default_user` - (Optional) When 'true', enables connecting to the database with the 'default' user across all regions. Default: 'true'. To disable, explicitly set to 'false'
 * `global_resp_version` - (Optional) Either 'resp2' or 'resp3'. Resp version for Crdb databases within the AA database. Must be compatible with Redis version.
 * `port` - (Optional) TCP port on which the database is available - must be between 10000 and 19999. **Modifying this attribute will force creation of a new resource.**
 * `override_region` - (Optional) Override region specific configuration, documented below
@@ -117,7 +117,7 @@ The `override_region` block supports:
 * `override_global_source_ips` - (Optional) List of source IP addresses or subnet masks that are allowed to connect to the database in this specific region, overriding the global `global_source_ips` setting (example: ['192.168.10.0/32', '192.168.12.0/24']). If not specified, the global `global_source_ips` setting applies to this region
 * `override_global_data_persistence` - (Optional) Regional instance of an Active-Active database data persistence rate (in persistent storage)
 * `remote_backup` - (Optional) Specifies the backup options for the database in this region, documented below
-* `enable_default_user` - (Optional) Whether the default user should be enabled or not. True by default.
+* `enable_default_user` - (Optional) Whether the default user should be enabled for this specific region. Default: 'true'. To disable the default user for this region, you must explicitly set this to 'false'
 
 The `override_global_alert` block supports:
 

provider/activeactive/testdata/enable_default_user_all_explicit.tf

@@ -2,7 +2,6 @@ package provider
 
 import (
 	"context"
-
 	"github.com/RedisLabs/rediscloud-go-api/redis"
 	fixedDatabases "github.com/RedisLabs/rediscloud-go-api/service/fixed/databases"
 	"github.com/RedisLabs/terraform-provider-rediscloud/provider/client"