Skip to content

Commit 3986ff9

Browse files
authored
Merge pull request #120 from RedisLabsModules/fixes_following_rdb_preamble_flag
Fix typo in compare env field
2 parents aab408d + 10e344d commit 3986ff9

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

RLTest/env.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ def getKwargs(self):
151151
class Env:
152152
RTestInstance = None
153153
EnvCompareParams = ['module', 'moduleArgs', 'env', 'useSlaves', 'shardsCount', 'useAof',
154-
'udsRdbPreamble', 'forceTcp']
154+
'useRdbPreamble', 'forceTcp']
155155

156156
def compareEnvs(self, env):
157157
if env is None:

tests/unit/test_env.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,19 @@ def test_get_env_str(self):
4040
self.env.stop()
4141
assert self.env.isUp() == False
4242

43+
def test_compare_env(self):
44+
self.env = Env(env='oss', logDir=self.test_dir, redisBinaryPath=REDIS_BINARY,
45+
redisEnterpriseBinaryPath=REDIS_ENTERPRISE_BINARY, dmcBinaryPath=DMC_PROXY_BINARY)
46+
env = Env(env='oss', logDir=self.test_dir, redisBinaryPath=REDIS_BINARY,
47+
redisEnterpriseBinaryPath=REDIS_ENTERPRISE_BINARY, dmcBinaryPath=DMC_PROXY_BINARY)
48+
assert self.env.compareEnvs(env) is True
49+
env.stop()
50+
env = Env(env='oss', logDir=self.test_dir, redisBinaryPath=REDIS_BINARY,
51+
redisEnterpriseBinaryPath=REDIS_ENTERPRISE_BINARY, dmcBinaryPath=DMC_PROXY_BINARY, useAof=True)
52+
assert self.env.compareEnvs(env) is False
53+
env.stop()
54+
self.env.stop()
55+
4356
def test_get_connection(self):
4457
pass
4558

0 commit comments

Comments
 (0)