Skip to content

Commit 481b254

Browse files
author
Meir Shpilraien (Spielrein)
authored
Revert 54d1b81 as it broke valgrind run. (#201)
Revert 262b22a as it broke valgrind run.
1 parent 262b22a commit 481b254

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,7 @@ jobs:
201201
- name: Upload coverage to Codecov
202202
uses: codecov/codecov-action@v3
203203
if: matrix.python == '3.9' && matrix.platform != 'macos-11'
204+
continue-on-error: true
204205
with:
205206
token: ${{ secrets.CODECOV_TOKEN }}
206207
file: ./coverage.xml

RLTest/redis_std.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ def __init__(self, redisBinaryPath, port=6379, modulePath=None, moduleArgs=None,
7878
self.port = -1
7979
self.slavePort = -1
8080

81+
if self.has_interactive_debugger and serverId > 1:
82+
assert self.noCatch and not self.useSlaves and not self.clusterEnabled
83+
8184
if self.useUnix:
8285
if self.clusterEnabled:
8386
raise ValueError('Unix sockets cannot be used with cluster mode')
@@ -170,7 +173,7 @@ def _getRedisVersion(self):
170173

171174
def createCmdArgs(self, role):
172175
cmdArgs = []
173-
if self.debugger and role == MASTER and self.masterServerId == 1:
176+
if self.debugger:
174177
cmdArgs += self.debugger.generate_command(self._getValgrindFilePath(role) if not self.noCatch else None)
175178

176179
cmdArgs += [self.redisBinaryPath]

0 commit comments

Comments
 (0)