Skip to content

Commit 6f22860

Browse files
authored
loglevel config (#194)
* added log level configuration for the redis instance * bump up RLTest version
1 parent 54d1b81 commit 6f22860

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

RLTest/__main__.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,10 @@ def do_normal_conn(self, line):
197197
'--log-dir', default='./logs',
198198
help='directory to write logs to')
199199

200+
parser.add_argument(
201+
'--log-level', default=None, metavar='LEVEL', choices=['debug', 'verbose', 'notice', 'warning'],
202+
help='sets the server log level')
203+
200204
parser.add_argument(
201205
'--use-slaves', action='store_const', const=True, default=False,
202206
help='run env with slaves enabled')
@@ -415,6 +419,7 @@ def __init__(self):
415419
Defaults.binary = self.args.oss_redis_path
416420
Defaults.verbose = self.args.verbose
417421
Defaults.logdir = self.args.log_dir
422+
Defaults.loglevel = self.args.log_level
418423
Defaults.use_slaves = self.args.use_slaves
419424
Defaults.num_shards = self.args.shards_count
420425
Defaults.shards_ports = self.args.shards_ports.split(',') if self.args.shards_ports is not None else None
@@ -746,7 +751,7 @@ def run_jobs(jobs, results, port):
746751
if failures > 0 and Defaults.print_verbose_information_on_failure:
747752
lastEnv = self.currEnv
748753
verboseInfo['before_dispose'] = lastEnv.getInformationBeforeDispose()
749-
754+
750755
# here the env is down so lets collect more info and print it
751756
if failures > 0 and Defaults.print_verbose_information_on_failure:
752757
verboseInfo['after_dispose'] = lastEnv.getInformationAfterDispose()

RLTest/env.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ class Defaults:
135135
exit_on_failure = False
136136
verbose = 0
137137
logdir = None
138+
loglevel = None
138139
use_slaves = False
139140
num_shards = 1
140141
external_addr = 'localhost:6379'
@@ -260,14 +261,14 @@ def __init__(self, testName=None, testDescription=None, module=None,
260261

261262
if Defaults.debug_pause:
262263
input('\tenv is up, attach to any process with gdb and press any button to continue.')
263-
264+
264265
def getInformationBeforeDispose(self):
265266
return {
266267
"env": self.env,
267268
"test": self.testName,
268269
"env_info": self.envRunner.getInformationBeforeDispose()
269270
}
270-
271+
271272
def getInformationAfterDispose(self):
272273
return self.envRunner.getInformationAfterDispose()
273274

@@ -333,6 +334,7 @@ def getEnvKwargs(self):
333334
'useAof': self.useAof,
334335
'useRdbPreamble': self.useRdbPreamble,
335336
'dbDirPath': self.logDir,
337+
'loglevel': Defaults.loglevel,
336338
'debugger': Defaults.debugger,
337339
'sanitizer': Defaults.sanitizer,
338340
'noCatch': Defaults.no_capture_output,

RLTest/redis_std.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def __init__(self, redisBinaryPath, port=6379, modulePath=None, moduleArgs=None,
2222
dbDirPath=None, useSlaves=False, serverId=1, password=None, libPath=None, clusterEnabled=False, decodeResponses=False,
2323
useAof=False, useRdbPreamble=True, debugger=None, sanitizer=None, noCatch=False, noLog=False, unix=False, verbose=False, useTLS=False,
2424
tlsCertFile=None, tlsKeyFile=None, tlsCaCertFile=None, clusterNodeTimeout=None, tlsPassphrase=None, enableDebugCommand=False, protocol=2,
25-
terminateRetries=None, terminateRetrySecs=None):
25+
terminateRetries=None, terminateRetrySecs=None, loglevel=None):
2626
self.uuid = uuid.uuid4().hex
2727
self.redisBinaryPath = os.path.expanduser(redisBinaryPath) if redisBinaryPath.startswith(
2828
'~/') else redisBinaryPath
@@ -42,6 +42,7 @@ def __init__(self, redisBinaryPath, port=6379, modulePath=None, moduleArgs=None,
4242
self.sanitizer = sanitizer
4343
self.noCatch = noCatch
4444
self.noLog = noLog
45+
self.loglevel = loglevel
4546
self.environ = os.environ.copy()
4647
self.useUnix = unix
4748
self.dbDirPath = dbDirPath
@@ -205,6 +206,8 @@ def createCmdArgs(self, role):
205206
cmdArgs += ['--logfile', '/dev/null']
206207
elif self.outputFilesFormat is not None and not self.noCatch:
207208
cmdArgs += ['--logfile', self._getFileName(role, '.log')]
209+
if self.loglevel is not None:
210+
cmdArgs += ['--loglevel', self.loglevel]
208211
if self.outputFilesFormat is not None:
209212
cmdArgs += ['--dbfilename', self._getFileName(role, '.rdb')]
210213
if role == SLAVE:

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "RLTest"
3-
version = "0.7.1"
3+
version = "0.7.2"
44
description="Redis Modules Test Framework, allow to run tests on redis and modules on a variety of environments"
55
authors = ["Redis, Inc. <[email protected]>"]
66
license = "BSD-3-Clause"

0 commit comments

Comments
 (0)