Native type works again: Removed mistaken freeing of memory

Author: gavrie

examples/data_type.rs

@@ -37,11 +37,11 @@ fn alloc_set(ctx: &Context, args: Vec<String>) -> RedisResult {
     } else {
         ctx.log_debug(format!("key exists; getting value").as_str());
 
-        let value: MyType = key.get_value(&MY_REDIS_TYPE)?;
+        let value: &mut MyType = key.get_value(&MY_REDIS_TYPE)?;
         ctx.log_debug(format!("got value: '{:?}'", value).as_str());
 
-        //value.data = "B".repeat(size as usize);
-        //ctx.log_debug(format!("new value: '{:?}'", value).as_str());
+        value.data = "B".repeat(size as usize);
+        ctx.log_debug(format!("new value: '{:?}'", value).as_str());
     };
 
     Ok(size.into())

src/context.rs

@@ -83,6 +83,10 @@ impl Context {
                 let msg = CString::new(s).unwrap();
                 raw::RedisModule_ReplyWithError.unwrap()(self.ctx, msg.as_ptr()).into()
             }
+
+            Err(RedisError::MissingValue) => unsafe {
+                raw::RedisModule_ReplyWithNull.unwrap()(self.ctx).into()
+            }
         }
     }
 

src/key.rs

@@ -173,20 +173,20 @@ impl RedisKeyWritable {
         Ok("OK".into())
     }
 
-    pub fn get_value<T: Default>(&self, redis_type: &RedisType) -> Result<T, RedisError> {
+    pub fn get_value<T: Default>(&self, redis_type: &RedisType) -> Result<&mut T, RedisError> {
         self.verify_type(redis_type)?;
 
         let value = unsafe {
             raw::RedisModule_ModuleTypeGetValue.unwrap()(self.key_inner) as *mut T
         };
 
         if value.is_null() {
-            return Ok(T::default());
+            return Err(RedisError::MissingValue);
         }
 
-        let value = unsafe { Box::from_raw(value) };
+        let value = unsafe { &mut *value };
 
-        Ok(*value)
+        Ok(value)
     }
 
     pub fn set_value<T: Debug>(&self, redis_type: &RedisType, value: T) -> Result<(), RedisError> {

src/redismodule.rs

@@ -11,6 +11,7 @@ pub enum RedisError {
     WrongArity,
     Str(&'static str),
     String(String),
+    MissingValue,
 }
 
 #[derive(Debug, PartialEq)]