clean clippy warnings (#209)

Author: gkorland

examples/keys_pos.rs

@@ -20,7 +20,7 @@ fn keys_pos(ctx: &Context, args: Vec<RedisString>) -> RedisResult {
 
     let reply: Vec<_> = args.iter().skip(1).step_by(2).collect();
 
-    return Ok(reply.into());
+    Ok(reply.into())
 }
 
 //////////////////////////////////////////////////////

src/context/mod.rs

@@ -141,7 +141,7 @@ impl Context {
         CString::new(
             s.chars()
                 .map(|c| match c {
-                    '\r' | '\n' => ' ' as u8,
+                    '\r' | '\n' => b' ',
                     _ => c as u8,
                 })
                 .collect::<Vec<_>>(),

src/key.rs

@@ -459,8 +459,8 @@ where
     let mut values_raw = [std::ptr::null_mut(); BATCH_SIZE];
 
     for chunk_fields in fields.chunks(BATCH_SIZE) {
-        let mut chunk_values = &mut values_raw[..chunk_fields.len()];
-        raw::hash_get_multi(key, chunk_fields, &mut chunk_values)?;
+        let chunk_values = &mut values_raw[..chunk_fields.len()];
+        raw::hash_get_multi(key, chunk_fields, chunk_values)?;
         values.extend(chunk_values.iter().map(|ptr| {
             if ptr.is_null() {
                 None

src/redismodule.rs

@@ -142,7 +142,7 @@ impl RedisString {
         Self::from_ptr(self.inner).map_err(|_| RedisError::Str("Couldn't parse as UTF-8 string"))
     }
 
-    pub fn as_slice<'a>(&self) -> &[u8] {
+    pub fn as_slice(&self) -> &[u8] {
         Self::string_as_slice(self.inner)
     }
 

tests/integration.rs

@@ -20,7 +20,7 @@ fn test_hello() -> Result<()> {
 
     let res: Result<Vec<i32>, RedisError> =
         redis::cmd("hello.mul").arg(&["3", "xx"]).query(&mut con);
-    if let Ok(_) = res {
+    if res.is_ok() {
         return Err(anyhow::Error::msg("Should return an error"));
     }
 
@@ -42,7 +42,7 @@ fn test_keys_pos() -> Result<()> {
 
     let res: Result<Vec<String>, RedisError> =
         redis::cmd("keys_pos").arg(&["a", "1", "b"]).query(&mut con);
-    if let Ok(_) = res {
+    if res.is_ok() {
         return Err(anyhow::Error::msg("Shold return an error"));
     }
 

tests/utils.rs

@@ -80,7 +80,7 @@ pub fn get_redis_connection(port: u64) -> Result<Connection> {
                     // Redis not ready yet, sleep and retry
                     std::thread::sleep(Duration::from_millis(50));
                 } else {
-                    Err(e)?;
+                    return Err(e.into());
                 }
             }
         }