Workaround to allow test-specific code in dependencies

Author: gavrie

.circleci/config.yml

@@ -56,4 +56,4 @@ jobs:
 
       - run:
           name: Run all tests
-          command: cargo test --features experimental-api --all
+          command: cargo test --features test,experimental-api --all-targets

Cargo.toml

@@ -36,3 +36,7 @@ cc = "1.0"
 default = []
 experimental-api = []
 
+# Workaround to allow cfg(feature = "test") in dependencies:
+# https://github.com/rust-lang/rust/issues/59168#issuecomment-472653680
+# This requires running the tests with `--features test`
+test = []

build.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env sh
+cargo build --features experimental-api --all --all-targets
+

src/context.rs

@@ -57,8 +57,8 @@ impl Context {
     }
 
     pub fn is_keys_position_request(&self) -> bool {
-        // HACK: Used for tests, where the context is null
-        if self.ctx.is_null() {
+        // We want this to be available in tests where we don't have an actual Redis to call
+        if cfg!(feature = "test") {
             return false;
         }
 

test.sh

@@ -0,0 +1,2 @@
+#!/usr/bin/env sh
+cargo test --all-targets --features test,experimental-api