Skip to content

Commit 80f50fe

Browse files
committed
Minor refactoring
Bumped JDK version to 17 Added TestContainers support Removed unused imports
1 parent 1e8c3af commit 80f50fe

File tree

6 files changed

+48
-16
lines changed

6 files changed

+48
-16
lines changed

.java-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
16
1+
17

README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,18 @@ Features in this demo:
1919

2020
## Prerequisites
2121

22-
1. JDK 11 or higher (https://openjdk.java.net/install/index.html)
22+
1. JDK 17 or higher (https://openjdk.java.net/install/index.html)
2323
2. Docker Desktop (https://www.docker.com/products/docker-desktop)
2424
3. Azure CLI (https://docs.microsoft.com/en-us/cli/azure/install-azure-cli)
2525
4. Azure Spring Cloud extension for the Azure CLI (https://docs.microsoft.com/en-us/cli/azure/spring-cloud?view=azure-cli-latest)
2626

2727
## Running locally
2828

2929
1. Checkout the project
30-
2. `docker run -p 6379:6379 redislabs/redismod:latest`
31-
3. `./mvnw clean package spring-boot:run`
32-
4. Navigate to http://localhost:8080 and login with user lars and password larsje
30+
2. `./mvnw clean package`
31+
3. `docker run -p 6379:6379 redislabs/redismod:latest`
32+
4. `./mvnw spring-boot:run`
33+
5. Navigate to http://localhost:8080 and login with user lars and password larsje
3334

3435
## Running on Azure Spring Cloud
3536

pom.xml

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<name>redisbank</name>
1414
<description>Demo project for Spring Boot</description>
1515
<properties>
16-
<java.version>11</java.version>
16+
<java.version>17</java.version>
1717
</properties>
1818
<dependencies>
1919
<dependency>
@@ -63,7 +63,7 @@
6363
<dependency>
6464
<groupId>org.projectlombok</groupId>
6565
<artifactId>lombok</artifactId>
66-
<version>1.18.20</version>
66+
<version>1.18.22</version>
6767
<optional>true</optional>
6868
</dependency>
6969
<dependency>
@@ -76,8 +76,30 @@
7676
<artifactId>reactor-test</artifactId>
7777
<scope>test</scope>
7878
</dependency>
79+
<dependency>
80+
<groupId>org.testcontainers</groupId>
81+
<artifactId>testcontainers</artifactId>
82+
<scope>test</scope>
83+
</dependency>
84+
<dependency>
85+
<groupId>org.testcontainers</groupId>
86+
<artifactId>junit-jupiter</artifactId>
87+
<scope>test</scope>
88+
</dependency>
7989
</dependencies>
8090

91+
<dependencyManagement>
92+
<dependencies>
93+
<dependency>
94+
<groupId>org.testcontainers</groupId>
95+
<artifactId>testcontainers-bom</artifactId>
96+
<version>1.16.2</version>
97+
<type>pom</type>
98+
<scope>import</scope>
99+
</dependency>
100+
</dependencies>
101+
</dependencyManagement>
102+
81103
<build>
82104
<plugins>
83105
<plugin>

src/main/java/com/redislabs/demos/redisbank/SerializationUtil.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.redislabs.demos.redisbank;
22

3-
import java.io.File;
43
import java.io.InputStream;
54
import java.text.SimpleDateFormat;
65
import java.util.Collections;

src/main/java/com/redislabs/demos/redisbank/transactions/TransactionOverviewController.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
import com.redislabs.lettusearch.SearchResults;
1515
import com.redislabs.lettusearch.StatefulRediSearchConnection;
1616

17-
import org.slf4j.Logger;
18-
import org.slf4j.LoggerFactory;
1917
import org.springframework.data.redis.core.StringRedisTemplate;
2018
import org.springframework.data.redis.core.ZSetOperations.TypedTuple;
2119
import org.springframework.web.bind.annotation.CrossOrigin;
@@ -29,8 +27,6 @@
2927
@CrossOrigin
3028
public class TransactionOverviewController {
3129

32-
private static final Logger LOGGER = LoggerFactory.getLogger(TransactionOverviewController.class);
33-
3430
private static final String ACCOUNT_INDEX = "transaction_account_idx";
3531
private static final String SEARCH_INDEX = "transaction_description_idx";
3632
private static final String BALANCE_TS = "balance_ts";
Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,27 @@
11
package com.redislabs.demos.redisbank;
22

3-
import org.junit.jupiter.api.Test;
43
import org.springframework.boot.test.context.SpringBootTest;
4+
import org.springframework.test.context.DynamicPropertyRegistry;
5+
import org.springframework.test.context.DynamicPropertySource;
6+
import org.testcontainers.containers.GenericContainer;
7+
import org.testcontainers.junit.jupiter.Container;
8+
import org.testcontainers.junit.jupiter.Testcontainers;
9+
import org.testcontainers.utility.DockerImageName;
510

611
@SpringBootTest
12+
@Testcontainers
713
class RedisbankApplicationTests {
814

9-
@Test
10-
void contextLoads() {
11-
}
15+
static final String REDIS_IMAGE = "redislabs/redismod:latest";
16+
static final int REDIS_PORT = 6379;
17+
18+
@Container
19+
static GenericContainer<?> redisContainer = new GenericContainer<>(DockerImageName.parse(REDIS_IMAGE))
20+
.withExposedPorts(REDIS_PORT);
1221

22+
@DynamicPropertySource
23+
static void redisProperties(DynamicPropertyRegistry registry) {
24+
registry.add("spring.redis.host", redisContainer::getContainerIpAddress);
25+
registry.add("spring.redis.port", redisContainer::getFirstMappedPort);
26+
}
1327
}

0 commit comments

Comments
 (0)