fix: validate plugins in extends (#2210)

Author: tatomyr

.changeset/eight-onions-visit.md

@@ -0,0 +1,6 @@
+---
+"@redocly/openapi-core": patch
+"@redocly/cli": patch
+---
+
+Fixed plugins validation in config files referenced in the `extends` section.

packages/core/src/config/__tests__/config-resolvers.test.ts

@@ -348,7 +348,7 @@ describe('resolveConfig', () => {
   it('should resolve `recommended-strict` ruleset correctly', async () => {
     const expectedStrict = JSON.parse(JSON.stringify(recommended)) as Omit<
       RawGovernanceConfig,
-      'extends'
+      'extends' | 'plugins'
     >;
     for (const section of Object.values(expectedStrict)) {
       for (let ruleName in section) {

packages/core/src/config/types.ts

@@ -55,6 +55,7 @@ export type DecoratorConfig = PreprocessorConfig;
 
 export type RawGovernanceConfig<T extends 'built-in' | undefined = undefined> = {
   extends?: string[];
+  plugins?: (string | Plugin)[];
 
   rules?: RuleMap<BuiltInCommonRuleId, RuleConfig, T>;
   oas2Rules?: RuleMap<BuiltInOAS2RuleId, RuleConfig, T>;
@@ -84,7 +85,7 @@ export type RawGovernanceConfig<T extends 'built-in' | undefined = undefined> =
   overlay1Decorators?: Record<string, DecoratorConfig>;
 };
 
-export type ResolvedGovernanceConfig = Omit<RawGovernanceConfig, 'extends'>;
+export type ResolvedGovernanceConfig = Omit<RawGovernanceConfig, 'extends' | 'plugins'>;
 
 export type PreprocessorsConfig = {
   oas3?: Oas3PreprocessorsSet;

packages/core/src/types/redocly-yaml.ts

@@ -2,7 +2,7 @@ import path from 'node:path';
 import { rootRedoclyConfigSchema } from '@redocly/config';
 import { listOf } from './index.js';
 import { SpecVersion, getTypes } from '../oas-types.js';
-import { isCustomRuleId } from '../utils.js';
+import { isCustomRuleId, omit } from '../utils.js';
 import { getNodeTypesFromJSONSchema } from './json-schema-adapter.js';
 import { normalizeTypes } from '../types/index.js';
 import { isAbsoluteUrl } from '../ref-utils.js';
@@ -212,6 +212,7 @@ const configGovernanceProperties: Record<
       } as PropType;
     },
   } as PropType,
+  plugins: { type: 'array', items: { type: 'string' } },
 
   rules: 'Rules',
   oas2Rules: 'Rules',
@@ -268,7 +269,7 @@ const createConfigApisProperties = (nodeTypes: Record<string, NodeType>): NodeTy
   ...nodeTypes['rootRedoclyConfigSchema.apis_additionalProperties'],
   properties: {
     ...nodeTypes['rootRedoclyConfigSchema.apis_additionalProperties']?.properties,
-    ...ConfigGovernance.properties,
+    ...omit(ConfigGovernance.properties, ['plugins']), // plugins are not allowed in apis
   },
 });
 

packages/core/src/utils.ts

@@ -291,3 +291,13 @@ export function getOwn(obj: Record<string, any>, key: string) {
 export type CollectFn = (value: unknown) => void;
 
 export type Exact<T extends object> = T & { [key: string]: undefined };
+
+export function omit<O extends object, K extends keyof O>(obj: O, keys: K[]): Omit<O, K> {
+  const result = { ...obj };
+
+  keys.forEach((key) => {
+    delete result[key];
+  });
+
+  return result;
+}