chore: changes after review

Author: DmitryAnansky

packages/cli/src/__tests__/commands/generate-arazzo.test.ts

@@ -3,16 +3,16 @@ import { generate } from '@redocly/respect-core';
 import { vi, describe, it, expect, beforeEach } from 'vitest';
 import { Config } from '@redocly/openapi-core';
 
-// Mock the generate function
 vi.mock('@redocly/respect-core', async () => {
-  const actual = await vi.importActual('@redocly/respect-core');
+  const actual = await vi.importActual<typeof import('@redocly/respect-core')>(
+    '@redocly/respect-core'
+  );
   return {
     ...actual,
     generate: vi.fn(),
   };
 });
 
-// Mock node:fs
 vi.mock('node:fs', async () => {
   return {
     writeFileSync: vi.fn(),
@@ -21,7 +21,6 @@ vi.mock('node:fs', async () => {
   };
 });
 
-// Mock @redocly/openapi-core
 vi.mock('@redocly/openapi-core', async () => {
   const actual = await vi.importActual('@redocly/openapi-core');
   return {

packages/cli/src/__tests__/commands/respect/respect.test.ts

@@ -18,7 +18,9 @@ vi.mock('node:fs', async () => {
 
 // Mock the run function
 vi.mock('@redocly/respect-core', async () => {
-  const actual = await vi.importActual('@redocly/respect-core');
+  const actual = await vi.importActual<typeof import('@redocly/respect-core')>(
+    '@redocly/respect-core'
+  );
   return {
     ...actual,
     run: vi.fn(),

packages/cli/src/index.ts

@@ -672,7 +672,6 @@ yargs(hideBin(process.argv))
           },
         }),
     (argv) => {
-      process.env.REDOCLY_CLI_COMMAND = 'eject';
       commandWrapper(handleEject)(argv as Arguments<EjectArgv>);
     }
   )

packages/respect-core/src/index.ts

@@ -1,7 +1,5 @@
-export { generate } from './generate.js';
-export { run } from './run.js';
-export type { GenerateArazzoOptions } from './generate.js';
-export type { RespectOptions } from './run.js';
+export { generate, type GenerateArazzoOptions } from './generate.js';
+export { run, type RespectOptions } from './run.js';
 export * from './types.js';
 export { maskSecrets } from './modules/logger-output/mask-secrets.js';
 export { calculateTotals } from './modules/logger-output/calculate-tests-passed.js';

packages/respect-core/src/modules/__tests__/config-parser/resolve-reusable-component-item.test.ts

@@ -10,7 +10,7 @@ describe('resolveReusableComponentItem', () => {
         options: {
           logger,
         },
-      } as unknown as TestContext)
+      } as Partial<TestContext> as TestContext)
     ).toEqual({
       in: 'query',
       name: 'test',
@@ -31,7 +31,7 @@ describe('resolveReusableComponentItem', () => {
           options: {
             logger,
           },
-        } as unknown as TestContext
+        } as Partial<TestContext> as TestContext
       )
     ).toEqual({
       name: 'SuccessActio',
@@ -47,7 +47,7 @@ describe('resolveReusableComponentItem', () => {
         options: {
           logger,
         },
-      } as unknown as TestContext)
+      } as Partial<TestContext> as TestContext)
     ).toThrow(
       'Invalid reference: available components are $components.parameters, $components.failureActions, or $components.successActions'
     );

packages/respect-core/src/modules/__tests__/flow-runner/call-api-and-analyze-results.test.ts

@@ -6,19 +6,8 @@ import {
 } from '../../flow-runner/index.js';
 import { ApiFetcher } from '../../../utils/api-fetcher.js';
 
-const originalFetch = global.fetch;
-
-beforeAll(() => {
-  // Reset fetch mock before each test
-  global.fetch = vi.fn();
-});
-
-afterAll(() => {
-  // Restore original fetch after each test
-  global.fetch = originalFetch;
-});
-
 describe('callAPIAndAnalyzeResults', () => {
+  const mockFetch = vi.fn();
   const apiClient = new ApiFetcher({});
   const ctx = {
     apiClient,
@@ -333,7 +322,7 @@ describe('callAPIAndAnalyzeResults', () => {
       maxSteps: 2000,
       maxFetchTimeout: 40_000,
       executionTimeout: 3_600_000,
-      fetch,
+      fetch: mockFetch,
     },
     'x-serverUrl': 'https://catfact.ninja/',
     info: {
@@ -364,7 +353,7 @@ describe('callAPIAndAnalyzeResults', () => {
       headers: new Headers(),
     };
 
-    vi.mocked(global.fetch).mockResolvedValue(mockResponse as any);
+    vi.mocked(mockFetch).mockResolvedValue(mockResponse as any);
 
     const result = await callAPIAndAnalyzeResults({
       ctx,

packages/respect-core/src/modules/__tests__/flow-runner/run-step.test.ts

@@ -24,7 +24,6 @@ vi.mock('../../flow-runner/call-api-and-analyze-results.js', () => ({
   callAPIAndAnalyzeResults: vi.fn(),
 }));
 
-// Add this mock for the direct import path used by helpers.ts
 vi.mock('../../logger-output/display-checks.js', () => ({
   displayChecks: vi.fn(),
 }));
@@ -3812,7 +3811,6 @@ describe('runStep', () => {
   });
 
   it('should report global timeout error and end execution', async () => {
-    // Mock Timer only for this test
     const mockTimer = {
       isTimedOut: vi.fn().mockReturnValue(true),
     };

packages/respect-core/src/modules/__tests__/flow-runner/runner/run-test-file.test.ts

@@ -11,7 +11,9 @@ import { type Step, type TestContext } from '../../../../types.js';
 import { runTestFile, runStep } from '../../../flow-runner/index.js';
 
 vi.mock('@redocly/openapi-core', async () => {
-  const originalModule = await vi.importActual('@redocly/openapi-core');
+  const originalModule = await vi.importActual<typeof import('@redocly/openapi-core')>(
+    '@redocly/openapi-core'
+  );
 
   return {
     ...originalModule, // Preserve other exports
@@ -79,7 +81,6 @@ describe('runTestFile', () => {
     });
     vi.mocked(lint).mockResolvedValue([]);
 
-    // Set up default mock for bundle to return proper structure
     vi.mocked(bundle).mockResolvedValue({
       bundle: {
         parsed: {

packages/respect-core/src/modules/context-parser/parse-request-body.ts

@@ -67,7 +67,6 @@ const getRequestBodyMultipartFormData = async (
 
 const getRequestBodyOctetStream = async (payload: RequestBody['payload'], ctx: TestContext) => {
   if (typeof payload === 'string' && payload.startsWith('$file(') && payload.endsWith(')')) {
-    // fixme, remove this
     const filePath = path.resolve(
       path.dirname(ctx.options.workflowPath),
       stripFileDecorator(payload)
@@ -115,7 +114,6 @@ export async function parseRequestBody(
     return {
       ...stepRequestBody,
       payload: formData,
-      // contentType: `multipart/form-data; boundary=${formData.getBoundary()}`,
     };
   } else if (
     contentType === 'application/octet-stream' ||

packages/respect-core/src/types.ts

@@ -255,7 +255,7 @@ export interface WorkflowExecutionResult {
   type: 'workflow';
   workflowId: string;
   stepId?: string; // for child workflows
-  sourceDescriptionName?: string; // maybe drop for now
+  sourceDescriptionName?: string;
 
   startTime: number;
   endTime: number;